Re: [PATCH] speed up SATA

Timothy Miller
2004-03-30T18:00:42Z

Jeff Garzik wrote:
>
>
>
> If you are taking your samples over time, that shouldn't matter... if
> the system workload is such that you are hitting the drive cache the
> majority of the time, you're not being "fooled" by cache hits, the patch
> would be taking those cache hits into account.
>
> If the system isn't hitting the drive cache the majority of the time,
> statistical sampling will automatically notice that too...
>

I completely agree, although Jens' patch seems to try to learn the
drive's maximum speed and go based on that. Maybe I misread the code.
Anyhow, it's certainly excellent for a starting point... it's this sort
of proof-of-concept that gets the ball rolling. Plus, it's already
better than Jens says it is. :)