RE: [PATCH 5/8] bsg: refactor bsg_ioctl

Avri Altman
2018-11-19T12:29:32Z

> On Sun, Nov 11, 2018 at 02:32:08PM +0100, Christoph Hellwig wrote:
> > Move all actual functionality into helpers, just leaving the dispatch
> > in this function.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > block/bsg.c | 158 ++++++++++++++++++++++++----------------------------
> > 1 file changed, 72 insertions(+), 86 deletions(-)
> >
>
> Looks fine to me. Did ran the same small test-tool I ran against Jens'
> patches, nothing broke.
>
> Reviewed-by: Benjamin Block <bblock@linux.ibm.com>
> Tested-by: Benjamin Block <bblock@linux.ibm.com>
Tested-by: Avri Altman <avri.altman@wdc.com>

Tested the scsi pass-through (ufs-bsg) path - nothing is broken.