From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750829AbdAWKFM (ORCPT ); Mon, 23 Jan 2017 05:05:12 -0500 Received: from mout.gmx.net ([212.227.15.19]:50502 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750725AbdAWKFJ (ORCPT ); Mon, 23 Jan 2017 05:05:09 -0500 From: Marc Dietrich To: Dmitry Torokhov Cc: Stephen Warren , Thierry Reding , Alexandre Courbot , Heikki Krogerus , linux-arm-kernel@lists.infradead.org, linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ARM: tegra: paz00: fix __initdata placement Date: Mon, 23 Jan 2017 11:04:22 +0100 Message-ID: <4072003.S1IBmddlP7@fb07-iapwap2> In-Reply-To: <20170123074347.GA29804@dtor-ws> References: <20170123074347.GA29804@dtor-ws> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="nextPart1515444.KbqjpeHriM"; micalg="pgp-sha256"; protocol="application/pgp-signature" X-Provags-ID: V03:K0:MzkwfOF3AU5C2qHbgPiYXrwFnPoIPm3a8+2LbupRImiIlEU0s9Z PY4OWWVmBKNjQ0URAqB0w+lNSgS3tI3kxuWjvhcD2e15i03ThMcv3j1AYpemhYcvfvktY1P GlkFTykru9gGmt599FPxMkHs+FvBvdCy8ssTVFNK3SEreq4WA4+a8LaCLFGUE+WMDU8erBA g1ObXjVFq4A38XhGKnNGg== X-UI-Out-Filterresults: notjunk:1;V01:K0:L6mXUoaWQVk=:bYITc18KvVIKIwsLHVk5yG MoMW3ceZ0p7P/EOA6NRQ/a7MkKdpRIBtsPp18mt1KObe12KocRhUg+vO3HC2kmBCUU43IFnUE cu+qNstosBt9/1ke8a6fVRSqa01fL7mgS6r8c8DJ5mN0AgI0s3QWVaxgToGD2HikE4fJuGQzO ZU1nDNeoSy0sqVYxLd20CWcd7bv6BBGeMTJqut7v9WJybxU3HV+clVvS7jj8x8AGmRU+OaNDV /usTiz/p3cJJEZWcxaEh2lH8t7aRljyPcFUU35N1KoGpyoEBmCZbP78LcakGi/YD3LvoCDhVG +IHmJCRe9gJ+Aaolu6Aumk5I3IVIvbWGUt3HmG6Hb1nE6D57Mw0uryivXe3jbGlAYMsugXqL1 RqREwiZmBdHbaTnVba+JCfuQOtTqUKjVRficfmX6GsA4K9dbGJLgjzRgjOQcJF05M2wkoZIY8 n8XMiAbjC4K1sWyydnpuuACglAJYehOtNjmgIEXTxuEEMCFEjdfpceY1S12NcqJlcYVIsSgbD rZSfdjwhfm7gyhu+5IVIC8czZLr1ysHfIAP+KS/pZDbzC33BZED0Rlzg7cuHzRX3HkRriTSQ+ uSwpG3vecPsJSrUq40VadKZWrEKTrLStw7yNVHHNoerX6mhP7B2be800UvrGSLlkYE/SIGR39 WufD1SFrNAemjCn2vTU+9iLUmh7hZFYGN8V+GG+SLTcNge7lcPIAuCbnCa4jvRqwoIrhVWy8I koQLB1Of+kzMzHmmg3oI+xb12veDOIJIwpgyXoI1aiTKGbp4JDeYoGbYWng= Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org --nextPart1515444.KbqjpeHriM Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Hello Dmitry, Am Sonntag, 22. Januar 2017, 23:43:47 CET schrieb Dmitry Torokhov: > To have expected effect the __initdata attribute should go after variable > name and before initializer.` > > Signed-off-by: Dmitry Torokhov > --- > arch/arm/mach-tegra/board-paz00.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm/mach-tegra/board-paz00.c > b/arch/arm/mach-tegra/board-paz00.c index 7478f6fb3664..ea6bff404161 100644 > --- a/arch/arm/mach-tegra/board-paz00.c > +++ b/arch/arm/mach-tegra/board-paz00.c > @@ -23,7 +23,7 @@ > > #include "board.h" > > -static struct property_entry __initdata wifi_rfkill_prop[] = { > +static struct property_entry wifi_rfkill_prop[] __initdata = { > PROPERTY_ENTRY_STRING("name", "wifi_rfkill"), > PROPERTY_ENTRY_STRING("type", "wlan"), > { }, you are right according to the documentation, but objdump -s always shows that it gets put into the .rodata section. So this patch has no effect, because result is always same (and wrong). It's also possible that I'm doing something wrong :-) Btw, there are hundreds of such __initdata misplacement in the kernel. Marc --nextPart1515444.KbqjpeHriM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part. Content-Transfer-Encoding: 7Bit -----BEGIN PGP SIGNATURE----- iQEzBAABCAAdFiEEySF+t0C8+8jyqfBvrJ5Hf0cUG2gFAliF1SYACgkQrJ5Hf0cU G2hfaQf/fsl3vXHhdUMFIA+As2aabIezAqCiNJ/D85q2+Ic5AEEzCc4EjVmpyyaS u6l9jATYuGcl4u4dOL0bnmnUD6U8gVFb4zc7RckTDndQ7eNJA7Hr1OgV8odJojme Soe93g4a6vOkCAZm6+RVwyOf8NykUX+qoPekasaLY3s3X6U7Ow5Ss8ulHhFQPBZT QJrG29bV3Xzb/pPkSZX21SZcMe0SgaH4Yu3ozQBsq9fbUNUE7KOtQu3Nj+oFDR6J YNZod7XsP/iF+g88GEnisZBUbWq+UeQ2hW3ituyFrs41dnbMidxpDJ51YnPQhXO9 mUOVwHnvQcJjt0UG3hbmUvrjYY7y3Q== =WlhV -----END PGP SIGNATURE----- --nextPart1515444.KbqjpeHriM--