From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S932453AbcBITii (ORCPT <rfc822;w@1wt.eu>);
	Tue, 9 Feb 2016 14:38:38 -0500
Received: from mout.kundenserver.de ([212.227.126.133]:64696 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753351AbcBITig (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 9 Feb 2016 14:38:36 -0500
From: Arnd Bergmann <arnd@arndb.de>
To: "Karicheri, Muralidharan" <m-karicheri2@ti.com>
Cc: David Laight <David.Laight@aculab.com>,
        "Strashko, Grygorii" <grygorii.strashko@ti.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
        "David S . Miller" <davem@davemloft.net>,
        "Cooper Jr., Franklin" <fcooper@ti.com>,
        "Nori, Sekhar" <nsekhar@ti.com>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "Kwok, WingMan" <w-kwok2@ti.com>,
        "N, Mugunthan V" <mugunthanvnm@ti.com>
Subject: Re: [PATCH] net: ti: netcp: restore get/set_pad_info() functionality
Date: Tue, 09 Feb 2016 20:38:19 +0100
Message-ID: <4072312.pCFuaqSbhC@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <3E54258959B69E4282D79E01AB1F32B704D12E49@DFLE11.ent.ti.com>
References: <1455026303-17014-1-git-send-email-grygorii.strashko@ti.com> <063D6719AE5E284EB5DD2968C1650D6D1CCDC216@AcuExch.aculab.com> <3E54258959B69E4282D79E01AB1F32B704D12E49@DFLE11.ent.ti.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:eo781g8h3jPPPi/z2CzuNroi4bjH6dZK8BZgu/0X1r3gpHq4nzK
 fyb3LKTic8WQQ/9nTMhRZSSZPoOdufro1TIlcFO4O4h+E0A6TxV2OJmkXxvx9Hp9sdBl0Hy
 YpbHxbYbzv/dpY38LlwYWDinKdt8F43qbqpCAfXyGr82i9KuLWjHtSYLtzhLNdMYGUTeVJN
 wGPpR5Gj+qonrcQN/rJRQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:MkcvJsS8xRo=:Sy32i5hhEwRPNF0Pat7/YV
 7JWpMHN0JU2HwgzaDXyE/7NYFklzPyHrAQJKpQ4Ri2zWqnerJBsCEmfGpV/nphAntLZhwgsmI
 QIXofuPHvy6CAJvvwPLy1UPAEUCIp/61InULq4dwq/Sp36en0eOwOWu8alCfKKYosQO5QG6WV
 gTjSRJ/gnXbz3TqdqoErdSUPJdJs3lne2s7ChiPMb8yb8sLAUM6hlF7nI2DRUZ0/ZVJsU64+q
 3DgqlmiVOi0rz9B9+HNRljuqpbayvXqS9NGGDtuTRLJ8qEfB8e+rliV5FgMYL6xiYlNsb3qIe
 Xn/oNY4q0+NWUc1HvjP0kwPiL4eyW8irjpe9Jd8LqOETuZRgkv/GX3MCCBwhco2LuhCuqx859
 t3s9/JXbMow0bqdLzwyReHJHA506k1m8XGQC+ETYfET/IYS+cS/rTrI/TZ3iNaJcYMWHupDgv
 7nrezcidi/6eTBk0XoIe/DkooNg+CJMzsBi13g1OaP2wm1dRTWMUFy6P3P+LfCUnEdREWJuQ7
 iNz49OyESEHpAsaRV2wzQQ9zFZcIvLU0ZMA5Ze5GVG2HPPkV0p9QM9enbE4QiH9fJOkDkoARz
 NDxrxlon6Lr7tzM5fPA6eKlp0tv0dZmzbM8g2yR2xVwREzY7ZClj/Xm9bjjo8k8WNvmbZFPy3
 CFHHWgUre3shPofBaidTVdVlyHX0RG4Gjr2FJm7rvEcpetgzemLIW7MQdevdVfhzTV2HD6xtN
 V8NE/BcybuFxNpAN
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tuesday 09 February 2016 16:55:42 Karicheri, Muralidharan wrote:
> 
> The descriptors are usable by different drivers, one driver may use it as 
> buf ptr/ len, other for something else. So they should remain as generic
> and it is up to individual drivers to use it in whatever way it requires.
> My suggestion is to rename pad field in struct knav_dma_desc to sw_data
> to avoid confusion. i.e 
> 
> +       __le32  pad[4];
> 
> to 
> 
> +       __le32  sw_data[4];
> 

If the hardware doesn't access them, they can probably just be u32
and not do any byte swapping.

	Arnd