From: SF Markus Elfring <elfring@users.sourceforge.net>
To: linux-media@vger.kernel.org,
Arvind Yadav <arvind.yadav.cs@gmail.com>,
Bhumika Goyal <bhumirks@gmail.com>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Mike Isely <isely@pobox.com>,
Sakari Ailus <sakari.ailus@linux.intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>, kernel-janitors@vger.kernel.org
Subject: [PATCH 1/5] [media] s2255drv: Delete three error messages for a failed memory allocation in s2255_probe()
Date: Wed, 20 Sep 2017 18:57:52 +0200 [thread overview]
Message-ID: <40736ede-e614-e498-8768-b8e5a1553f34@users.sourceforge.net> (raw)
In-Reply-To: <55718a41-d76f-36bf-7197-db92014dcd3c@users.sourceforge.net>
From: Markus Elfring <elfring@users.sourceforge.net>
Date: Wed, 20 Sep 2017 16:30:13 +0200
Omit extra messages for a memory allocation failure in this function.
This issue was detected by using the Coccinelle software.
Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
---
drivers/media/usb/s2255/s2255drv.c | 13 ++++---------
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/media/usb/s2255/s2255drv.c b/drivers/media/usb/s2255/s2255drv.c
index b2f239c4ba42..29285e8cd742 100644
--- a/drivers/media/usb/s2255/s2255drv.c
+++ b/drivers/media/usb/s2255/s2255drv.c
@@ -2242,13 +2242,9 @@ static int s2255_probe(struct usb_interface *interface,
- if (dev == NULL) {
- s2255_dev_err(&interface->dev, "out of memory\n");
+ if (!dev)
return -ENOMEM;
- }
dev->cmdbuf = kzalloc(S2255_CMDBUF_SIZE, GFP_KERNEL);
- if (dev->cmdbuf == NULL) {
- s2255_dev_err(&interface->dev, "out of memory\n");
+ if (!dev->cmdbuf)
goto errorFWDATA1;
- }
atomic_set(&dev->num_channels, 0);
dev->pid = id->idProduct;
@@ -2303,7 +2299,6 @@ static int s2255_probe(struct usb_interface *interface,
- if (!dev->fw_data->pfw_data) {
- dev_err(&interface->dev, "out of memory!\n");
+ if (!dev->fw_data->pfw_data)
goto errorFWDATA2;
- }
+
/* load the first chunk */
if (request_firmware(&dev->fw_data->fw,
FIRMWARE_FILE_NAME, &dev->udev->dev)) {
--
2.14.1
next prev parent reply other threads:[~2017-09-20 16:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-09-20 16:55 [PATCH 0/5] [media] s2255drv: Fine-tuning for some function implementations SF Markus Elfring
2017-09-20 16:57 ` SF Markus Elfring [this message]
2017-09-20 16:58 ` [PATCH 2/5] [media] s2255drv: Adjust 13 checks for null pointers SF Markus Elfring
2017-09-20 23:07 ` Dan Carpenter
2017-09-21 8:12 ` SF Markus Elfring
2017-09-21 9:22 ` Dan Carpenter
2017-09-21 11:23 ` SF Markus Elfring
2017-09-20 17:00 ` [PATCH 3/5] [media] s2255drv: Improve two size determinations in s2255_probe() SF Markus Elfring
2017-09-20 17:01 ` [PATCH 4/5] [media] s2255drv: Use common error handling code in read_pipe_completion() SF Markus Elfring
2017-09-20 17:02 ` [PATCH 5/5] [media] s2255drv: Delete an unnecessary return statement in five functions SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40736ede-e614-e498-8768-b8e5a1553f34@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=arvind.yadav.cs@gmail.com \
--cc=bhumirks@gmail.com \
--cc=isely@pobox.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).