From: Jon Grimm <jgrimm2@us.ibm.com>
To: Philippe Elie <phil.el@wanadoo.fr>
Cc: linux-kernel@vger.kernel.org, "Maciej @. Rozycki" <macro@ds2.pg.gda.pl>
Subject: Re: io_apic & timer_ack fix
Date: Fri, 09 Apr 2004 10:26:05 -0500 [thread overview]
Message-ID: <4076C08D.1000408@us.ibm.com> (raw)
In-Reply-To: <20040409163017.GA392@zaniah>
Philippe Elie wrote:
>On Fri, 09 Apr 2004 at 08:39 +0000, Jon Grimm wrote:
>
>
>
>>Hmmm....
>>
>>I see that the following patch got pulled in by Andrew:
>>http://linux.bkbits.net:8080/linux-2.5/diffs/arch/i386/kernel/io_apic.c@1.85?nav=index.html|src/|src/arch|src/arch/i386|src/arch/i386/kernel|hist/arch/i386/kernel/io_apic.c
>>
>>The patch had a couple bugs:
>>http://seclists.org/lists/linux-kernel/2004/Mar/4152.html
>>
>>But the patch was pulled out entirely by Linus:
>>http://linux.bkbits.net:8080/linux-2.5/diffs/arch/i386/kernel/io_apic.c@1.88?nav=index.html|src/|src/arch|src/arch/i386|src/arch/i386/kernel|hist/arch/i386/kernel/io_apic.c
>>
>>Was it determined that the fix was bogus? damaging? fixable?
>>
>>
>
>http://marc.theaimsgroup.com/?l=linux-kernel&m=107840458123059&w=2
>
>what's the right fix ? This patch fix timer_ack in three place, the
>two last look like typo (spurious ';' after if ()), the first chunk
>apparently cause higher temp on some mobo.
>
>
>
I have the spurious ';' removed in my testing.
>>I ask as I see behavior identical for which this patch seems to have
>>been originally carved up for (buggy SMM BIOS at fault, but this was a
>>workaround in the OS).
>>
>>http://marc.theaimsgroup.com/?l=linux-kernel&m=101604672921823&w=2
>>http://www.ussg.iu.edu/hypermail/linux/kernel/0203.2/0698.html
>>
>>Its a fair answer to force the BIOS vendor to fix, but in the meantime,
>>I'm trying to figure out how safe/unsafe the workaround patch is ?
>>I've ran on it overnight (with the semi-colon's fixed) and it hasn't
>>exhibited the troubling behavior (where timer interrupts seem stuck or
>>in some cases just extremely slow.... and the 8259 IMR is mucked up when
>>Linux isn't even touching anymore).
>>
>>
>
>I agree but actually it cause trouble for non bugged mobo, can this fixed ?
>
>
>
I hope. It looks like a real problem on a box I have.
>regards,
>Philippe Elie
>
>
next prev parent reply other threads:[~2004-04-09 15:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-09 13:39 io_apic & timer_ack fix Jon Grimm
2004-04-09 16:30 ` Philippe Elie
2004-04-09 15:26 ` Jon Grimm [this message]
-- strict thread matches above, loose matches on Subject: below --
2004-04-09 17:37 Ross Dickson
2004-04-13 12:20 ` Maciej W. Rozycki
2004-04-14 4:53 ` Jon Grimm
2004-04-14 10:14 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4076C08D.1000408@us.ibm.com \
--to=jgrimm2@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@ds2.pg.gda.pl \
--cc=phil.el@wanadoo.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox