public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	Linux Kernel Development <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 427] Amiga Zorro8390 Ethernet section conflict
Date: Tue, 13 Apr 2004 12:35:22 -0400	[thread overview]
Message-ID: <407C16CA.6010503@pobox.com> (raw)
In-Reply-To: <200404130838.i3D8c6pa018442@callisto.of.borg>

Geert Uytterhoeven wrote:
> Zorro8390: const data cannot be in the init data section (from Roman Zippel)

ACK, but this patch highlights a bug:

one is __initdata:

	static const struct card_info {
	    zorro_id id;
	    const char *name;
	    unsigned int offset;
	} cards[] __initdata = {

and the lone caller is __devinit:

static int __devinit zorro8390_init_one(struct zorro_dev *z,
                                       const struct zorro_device_id *ent)


  reply	other threads:[~2004-04-13 16:35 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-04-13  8:38 [PATCH 427] Amiga Zorro8390 Ethernet section conflict Geert Uytterhoeven
2004-04-13 16:35 ` Jeff Garzik [this message]
2004-04-15 18:39   ` Geert Uytterhoeven

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=407C16CA.6010503@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox