public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] netpoll transmit busy bugfix
@ 2004-04-10 20:34 Matt Mackall
  2004-04-13 18:08 ` Jeff Garzik
  0 siblings, 1 reply; 2+ messages in thread
From: Matt Mackall @ 2004-04-10 20:34 UTC (permalink / raw)
  To: Andrew Morton, linux-kernel; +Cc: Stelian Pop, Jeff Garzik

Fix for handling of full transmit queue when netpoll trap is enabled.

>From Stelian Pop <stelian@popies.net>

%patch
Index: mm/net/core/netpoll.c
===================================================================
--- mm.orig/net/core/netpoll.c	2004-04-10 15:15:25.000000000 -0500
+++ mm/net/core/netpoll.c	2004-04-10 15:19:31.000000000 -0500
@@ -163,21 +163,15 @@
 	spin_lock(&np->dev->xmit_lock);
 	np->dev->xmit_lock_owner = smp_processor_id();
 
-	if (netif_queue_stopped(np->dev)) {
-		np->dev->xmit_lock_owner = -1;
-		spin_unlock(&np->dev->xmit_lock);
-
-		netpoll_poll(np);
-		goto repeat;
-	}
-
 	status = np->dev->hard_start_xmit(skb, np->dev);
 	np->dev->xmit_lock_owner = -1;
 	spin_unlock(&np->dev->xmit_lock);
 
 	/* transmit busy */
-	if(status)
+	if(status) {
+		netpoll_poll(np);
 		goto repeat;
+	}
 }
 
 void netpoll_send_udp(struct netpoll *np, const char *msg, int len)

%diffstat
 netpoll.c |   12 +++---------
 1 files changed, 3 insertions(+), 9 deletions(-)



-- 
Matt Mackall : http://www.selenic.com : Linux development and consulting

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] netpoll transmit busy bugfix
  2004-04-10 20:34 [PATCH] netpoll transmit busy bugfix Matt Mackall
@ 2004-04-13 18:08 ` Jeff Garzik
  0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2004-04-13 18:08 UTC (permalink / raw)
  To: Matt Mackall; +Cc: Andrew Morton, linux-kernel, Stelian Pop

applied



^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-04-13 18:08 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-10 20:34 [PATCH] netpoll transmit busy bugfix Matt Mackall
2004-04-13 18:08 ` Jeff Garzik

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox