From: Jeff Garzik <jgarzik@pobox.com>
To: Tim Hockin <thockin@hockin.org>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] conditionalize some boring buffer_head checks
Date: Wed, 14 Apr 2004 04:48:23 -0400 [thread overview]
Message-ID: <407CFAD7.4070606@pobox.com> (raw)
In-Reply-To: <20040414082716.GA25439@hockin.org>
Tim Hockin wrote:
> Somewhat off the original topic, but am I the only one who finds it weird
> (and error-prone) that you have to add the same KConfig to a dozen or more
> Kconfig files?
>
> Shouldn't there be a KConfig libe, and all you need to do for the arch is
> reference the CONFIG_FOO from the lib? Would at least save all the
> duplicate strings and definitions...
>
> Kconfig.lib:
> config DEBUG_BUFFERS
> bool "Enable additional filesystem buffer_head checks"
> depends on DEBUG_KERNEL
> help
> If you say Y here, additional checks are performed that
> aid filesystem development.
>
> arch/*/Kconfig
> libpath /Kconfig.lib
> ...
> insert DEBUG_BUFFERS
> ...
Seems a lot easier just to gather the common definitions into a Kconfig
file, and include it via the standard 'source' directive.
Jeff
next prev parent reply other threads:[~2004-04-14 8:51 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-14 7:43 [PATCH] conditionalize some boring buffer_head checks Jeff Garzik
2004-04-14 7:58 ` Andrew Morton
2004-04-14 8:02 ` Andrew Morton
2004-04-14 8:10 ` Jeff Garzik
2004-04-14 8:16 ` Andrew Morton
2004-04-14 8:45 ` Jeff Garzik
2004-04-14 9:10 ` Jeff Garzik
2004-04-14 21:25 ` Matt Mackall
2004-04-14 21:27 ` Randy.Dunlap
2004-04-14 21:37 ` Matt Mackall
2004-04-14 21:33 ` Jeff Garzik
2004-04-14 21:49 ` Matt Mackall
2004-04-15 6:12 ` Zwane Mwaikambo
2004-04-15 20:52 ` PATCH] Kconfig.debug family Randy.Dunlap
2004-04-15 21:36 ` Sam Ravnborg
2004-04-15 21:36 ` Marc-Christian Petersen
2004-04-15 21:41 ` Randy.Dunlap
2004-04-14 8:27 ` [PATCH] conditionalize some boring buffer_head checks Tim Hockin
2004-04-14 8:48 ` Jeff Garzik [this message]
2004-04-14 13:31 ` Chris Friesen
2004-04-14 15:05 ` Randy.Dunlap
2004-04-14 8:29 ` Jens Axboe
2004-04-14 8:42 ` Jeff Garzik
2004-04-14 8:47 ` Jens Axboe
[not found] <1KNjN-gZ-9@gated-at.bofh.it>
[not found] ` <1KNDc-Bv-9@gated-at.bofh.it>
[not found] ` <1KNDg-Bv-25@gated-at.bofh.it>
[not found] ` <1KNMQ-Hs-15@gated-at.bofh.it>
[not found] ` <1KNWA-OH-25@gated-at.bofh.it>
2004-04-14 12:14 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407CFAD7.4070606@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=thockin@hockin.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox