From: David Brownell <david-b@pacbell.net>
To: Colin Leroy <colin@colino.net>
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] 2.6.6-rc1: cdc-acm still (differently) broken
Date: Thu, 15 Apr 2004 12:59:33 -0700 [thread overview]
Message-ID: <407EE9A5.3020305@pacbell.net> (raw)
In-Reply-To: <20040415212334.4a568c5a@jack.colino.net>
Hi Colin,
>>That test has always been buggy -- better to just remove it. For
>>that matter, usb_interface_claimed() calls should all vanish ... it's
>>better to fail if claiming the interface fails (one step, not two).
>>Care to try an updated patch?
>
>
> Like this one? It works. I'm a bit wondering, however, how comes
> usb_interface_claimed() returns true, and the check in
> usb_driver_claim_interface() passes?
Pretty much like that one, but not leaking the other urbs ... :)
There are two interfaces involved, for "control" and "data".
"Control" is being probed; and "data" is what gets claimed.
For more info, you could see how "usbnet" handles CDC Ethernet;
see how it parses the CDC Union descriptor (which is what the
FIXME refers to). Or read the CDC spec, from www.usb.org as PDF.
- Dave
next prev parent reply other threads:[~2004-04-15 19:58 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-15 18:11 2.6.6-rc1: cdc-acm still (differently) broken Colin Leroy
2004-04-15 18:50 ` [linux-usb-devel] " Oliver Neukum
2004-04-15 18:54 ` David Brownell
2004-04-15 19:23 ` Colin Leroy
2004-04-15 19:59 ` David Brownell [this message]
2004-04-16 10:24 ` Colin Leroy
2004-04-16 18:44 ` David Brownell
2004-04-16 21:48 ` [PATCH] " Colin Leroy
2004-04-17 9:54 ` Colin Leroy
2004-04-15 20:24 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=407EE9A5.3020305@pacbell.net \
--to=david-b@pacbell.net \
--cc=colin@colino.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox