From: David Brownell <david-b@pacbell.net>
To: Colin Leroy <colin@colino.net>
Cc: linux-kernel@vger.kernel.org, linux-usb-devel@lists.sourceforge.net
Subject: Re: [linux-usb-devel] 2.6.6-rc1: cdc-acm still (differently) broken
Date: Fri, 16 Apr 2004 11:44:10 -0700 [thread overview]
Message-ID: <4080297A.1090002@pacbell.net> (raw)
In-Reply-To: <20040416122415.6f532584@jack.colino.net>
Hi Colin,
> Here's another patch, which fixes the leak. It also fixes the
> FIXME, by looking at all interfaces to find the data one. Is it correct ?
It's looking better, but what I'd rather see is code scanning the
CDC descriptors (see "usbnet"). The deal is that there's actually
no guarantee that there's only one data interface, although that
seems to hold true for many current products.
But unless you're interested in finishing a much-needed rewrite
of that cdc-acm probe() code, this might be a good place to stop.
(Or at least pause!)
- Dave
next prev parent reply other threads:[~2004-04-16 18:43 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-15 18:11 2.6.6-rc1: cdc-acm still (differently) broken Colin Leroy
2004-04-15 18:50 ` [linux-usb-devel] " Oliver Neukum
2004-04-15 18:54 ` David Brownell
2004-04-15 19:23 ` Colin Leroy
2004-04-15 19:59 ` David Brownell
2004-04-16 10:24 ` Colin Leroy
2004-04-16 18:44 ` David Brownell [this message]
2004-04-16 21:48 ` [PATCH] " Colin Leroy
2004-04-17 9:54 ` Colin Leroy
2004-04-15 20:24 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4080297A.1090002@pacbell.net \
--to=david-b@pacbell.net \
--cc=colin@colino.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox