From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S263666AbUDPTfJ (ORCPT ); Fri, 16 Apr 2004 15:35:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S263657AbUDPTfJ (ORCPT ); Fri, 16 Apr 2004 15:35:09 -0400 Received: from parcelfarce.linux.theplanet.co.uk ([195.92.249.252]:36571 "EHLO www.linux.org.uk") by vger.kernel.org with ESMTP id S263653AbUDPTfA (ORCPT ); Fri, 16 Apr 2004 15:35:00 -0400 Message-ID: <40803553.2030403@pobox.com> Date: Fri, 16 Apr 2004 15:34:43 -0400 From: Jeff Garzik User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.4) Gecko/20030703 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "Mukker, Atul" CC: "'Christoph Hellwig'" , "Bagalkote, Sreenivas" , "'Matt_Domsch@dell.com'" , "'paul@kungfoocoder.org'" , "'James.Bottomley@SteelEye.com'" , "'arjanv@redhat.com'" , "'linux-scsi@vger.kernel.org'" , "'linux-kernel@vger.kernel.org'" Subject: Re: [ANNOUNCE][RELEASE]: megaraid unified driver version 2.20.0.B 1 References: <0E3FA95632D6D047BA649F95DAB60E57033BC53D@exa-atlanta.se.lsil.com> <40803154.3070707@pobox.com> In-Reply-To: <40803154.3070707@pobox.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org Jeff Garzik wrote: > If there is a static maximum of scbs for megaraid hardware, dynamically > allocating scbs in ->queuecommand is a waste of time. > > In my drivers, I pre-allocate driver-specific per-request structures -- > just like the SCSI layer does ;-) Slight correction... it looks like SCSI dynamically allocates requests these days. That doesn't change my core argument, however. Jeff