From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Jones <davej@redhat.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: yam driver null deref
Date: Fri, 16 Apr 2004 17:49:37 -0400 [thread overview]
Message-ID: <408054F1.4050506@pobox.com> (raw)
In-Reply-To: <20040416212507.GP20937@redhat.com>
Dave Jones wrote:
> --- linux-2.6.5/drivers/net/hamradio/yam.c~ 2004-04-16 22:24:00.000000000 +0100
> +++ linux-2.6.5/drivers/net/hamradio/yam.c 2004-04-16 22:24:32.000000000 +0100
> @@ -919,9 +919,12 @@
> static int yam_close(struct net_device *dev)
> {
> struct sk_buff *skb;
> - struct yam_port *yp = (struct yam_port *) dev->priv;
> + struct yam_port *yp;
>
> - if (!dev || !yp)
> + if (!dev)
> + return -EINVAL;
> + yp = dev->priv;
> + if (!yp)
> return -EINVAL;
Ditto... dev will never be NULL here. And most likely not dev->priv
either.
Jeff
prev parent reply other threads:[~2004-04-16 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:25 yam driver null deref Dave Jones
2004-04-16 21:49 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=408054F1.4050506@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox