From: Jeff Garzik <jgarzik@pobox.com>
To: David Gibson <david@gibson.dropbear.id.au>
Cc: Dave Jones <davej@redhat.com>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: orinoco potentially dereferencing before check
Date: Mon, 19 Apr 2004 12:22:32 -0400 [thread overview]
Message-ID: <4083FCC8.70203@pobox.com> (raw)
In-Reply-To: <20040417112549.GA32444@zax>
David Gibson wrote:
> On Fri, Apr 16, 2004 at 10:18:26PM +0100, Dave Jones wrote:
>
>>+++ linux-2.6.5/drivers/net/wireless/orinoco_pci.c 2004-04-16 22:17:30.000000000 +0100
>>@@ -275,14 +275,16 @@
>> static void __devexit orinoco_pci_remove_one(struct pci_dev *pdev)
>> {
>> struct net_device *dev = pci_get_drvdata(pdev);
>>- struct orinoco_private *priv = dev->priv;
>>+ struct orinoco_private *priv;
>>
>> if (! dev)
>> BUG();
>>
>>+ priv = dev->priv;
>>+
>> unregister_netdev(dev);
>>
>>- if (dev->irq)
>>+ if (dev->irq)
>> free_irq(dev->irq, dev);
>>
>> if (priv->hw.iobase)
>>-
>
>
> Better to just remove the if (! dev) BUG(). I don't believe we've
> ever hit that particular BUG() in debugging, so there's probably not
> much point having it.
done.
Jeff
prev parent reply other threads:[~2004-04-19 16:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:18 orinoco potentially dereferencing before check Dave Jones
2004-04-17 11:25 ` David Gibson
2004-04-19 16:22 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4083FCC8.70203@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox