From: Jeff Garzik <jgarzik@pobox.com>
To: Dave Jones <davej@redhat.com>
Cc: viro@parcelfarce.linux.theplanet.co.uk,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: baycom_par dereference before check.
Date: Mon, 19 Apr 2004 12:39:43 -0400 [thread overview]
Message-ID: <408400CF.6010203@pobox.com> (raw)
In-Reply-To: <20040416215319.GW20937@redhat.com>
Dave Jones wrote:
> On Fri, Apr 16, 2004 at 05:48:57PM -0400, Jeff Garzik wrote:
>
> > >Good point. Still doesn't strike me as particularly nice though.
> > I would rather just remove the checks completely. The success of any of
> > those checks is a BUG() condition that should never occur.
>
> That works for me too. How about this?
>
> Dave
>
> --- linux-2.6.5/drivers/net/hamradio/baycom_par.c~ 2004-04-16 22:52:35.000000000 +0100
> +++ linux-2.6.5/drivers/net/hamradio/baycom_par.c 2004-04-16 22:52:53.000000000 +0100
> @@ -274,8 +274,8 @@
> struct net_device *dev = (struct net_device *)dev_id;
> struct baycom_state *bc = netdev_priv(dev);
>
> - if (!dev || !bc || bc->hdrv.magic != HDLCDRV_MAGIC)
> - return;
> + BUG_ON(!bc);
> + BUG_ON(bc->hdrv.magic != HDLCDRV_MAGIC);
I applied a patch which simplied removed the checks.
Jeff
prev parent reply other threads:[~2004-04-19 16:40 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-04-16 21:20 baycom_par dereference before check Dave Jones
2004-04-16 21:25 ` viro
2004-04-16 21:27 ` Dave Jones
2004-04-16 21:48 ` Jeff Garzik
2004-04-16 21:53 ` Dave Jones
2004-04-16 23:07 ` Chris Wright
2004-04-16 23:40 ` Jeff Garzik
2004-04-19 16:39 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=408400CF.6010203@pobox.com \
--to=jgarzik@pobox.com \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@parcelfarce.linux.theplanet.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox