Sensors (W83627HF) in Tyan S2882

Sensors (W83627HF) in Tyan S2882

[Jan Kasprzak]

	Hello, world!\n

	I have two systems with Tyan S2882 boards (K8S Pro). The sensors chip
is Winbond w83627hf according to the mainboard documentation.  The w83627hf
driver can read values from the sensors, but apparently not all values.
The board has six fan connectors (two labeled CPU1 fan and CPU2 fan,
and four chassis fans). BIOS displays the fan status correctly for all fans,
so all fans are connected to the sensors chip. However, there are only three
fans listed in /sys/devices/platform/i2c-1/1-0290.

	Is it possible to read status of other three fans from Linux?

	Thanks,

-Yenya

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/   Czech Linux Homepage: http://www.linux.cz/ |
 Any compiler or language that likes to hide things like memory allocations
 behind your back just isn't a good choice for a kernel.   --Linus Torvalds

Re: Sensors (W83627HF) in Tyan S2882

[Marc Bevand]

Jan Kasprzak wrote:
> 	Hello, world!\n
> 
> 	I have two systems with Tyan S2882 boards (K8S Pro). The sensors chip
> is Winbond w83627hf according to the mainboard documentation.  The w83627hf
> driver can read values from the sensors, but apparently not all values.
> The board has six fan connectors (two labeled CPU1 fan and CPU2 fan,
> and four chassis fans). BIOS displays the fan status correctly for all fans,
> so all fans are connected to the sensors chip. However, there are only three
> fans listed in /sys/devices/platform/i2c-1/1-0290.

On the S2885 (not your model), 2 fans are handled by the w83627hf, and 4 others
by an adt7463. I see that the S2882 has an adm1027, maybe this is the chip that
handles your 3 others fans ?

-- 
Marc Bevand                          http://www.epita.fr/~bevand_m
Computer Science School EPITA - System, Network and Security Dept.

Re: Sensors (W83627HF) in Tyan S2882

[Fabian Fenaut]

Jan Kasprzak a écrit le 19.04.2004 14:01:
> 
> I have two systems with Tyan S2882 boards (K8S Pro). The sensors chip is
> Winbond w83627hf according to the mainboard documentation.  The w83627hf 
> driver can read values from the sensors, but apparently not all values. The
> board has six fan connectors (two labeled CPU1 fan and CPU2 fan, and four
> chassis fans). BIOS displays the fan status correctly for all fans, so all
> fans are connected to the sensors chip. However, there are only three fans
> listed in /sys/devices/platform/i2c-1/1-0290.


Probably unrelated to your problem, but isn't there a typo in 
drivers/i2c/chips/Kconfig ? maybe patch below ?

--
Fabian


diff -Nru drivers/i2c/chips/Kconfig.orig drivers/i2c/chips/Kconfig
--- drivers/i2c/chips/Kconfig.orig      Fri Apr 16 11:12:17 2004
+++ drivers/i2c/chips/Kconfig   Mon Apr 19 15:23:48 2004
@@ -158,7 +158,7 @@
           will be called via686a.

  config SENSORS_W83781D
-       tristate "Winbond W83781D, W83782D, W83783S, W83627HF, Asus AS99127F"
+       tristate "Winbond W83781D, W83782D, W83783S, W83682HF, Asus AS99127F"
         depends on I2C && EXPERIMENTAL
         select I2C_SENSOR
         help

Re: Sensors (W83627HF) in Tyan S2882

[Jean Delvare]

Hi Fabian,

> Probably unrelated to your problem, but isn't there a typo in 
> drivers/i2c/chips/Kconfig ? maybe patch below ?
> 
> diff -Nru drivers/i2c/chips/Kconfig.orig drivers/i2c/chips/Kconfig
> --- drivers/i2c/chips/Kconfig.orig      Fri Apr 16 11:12:17 2004
> +++ drivers/i2c/chips/Kconfig   Mon Apr 19 15:23:48 2004
> @@ -158,7 +158,7 @@
>            will be called via686a.
> 
>  config SENSORS_W83781D
> -       tristate "Winbond W83781D, W83782D, W83783S, W83627HF, Asus
AS99127F"
> +       tristate "Winbond W83781D, W83782D, W83783S, W83682HF, Asus
AS99127F"
>          depends on I2C && EXPERIMENTAL
>          select I2C_SENSOR
>          help

Nice catching. However the fix is not correct. "W83627HF" is the correct
name and "W83682HF" is the typo.

Care to send the correct fix to Greg? Please CC: me or the lm_sensors
mailing-list so that I can enqueue the patch on my side.

Thanks.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Re: Sensors (W83627HF) in Tyan S2882

[Fabian Fenaut]

Jean Delvare a écrit le 19.04.2004 17:18:
> Hi Fabian,
> 
>>diff -Nru drivers/i2c/chips/Kconfig.orig drivers/i2c/chips/Kconfig
>>--- drivers/i2c/chips/Kconfig.orig      Fri Apr 16 11:12:17 2004
>>+++ drivers/i2c/chips/Kconfig   Mon Apr 19 15:23:48 2004
>>@@ -158,7 +158,7 @@
>>           will be called via686a.
>>
>> config SENSORS_W83781D
>>-       tristate "Winbond W83781D, W83782D, W83783S, W83627HF, Asus AS99127F"
>>+       tristate "Winbond W83781D, W83782D, W83783S, W83682HF, Asus AS99127F"
>>         depends on I2C && EXPERIMENTAL
>>         select I2C_SENSOR
>>         help
> 
> 
> Nice catching. However the fix is not correct. "W83627HF" is the correct
> name and "W83682HF" is the typo.

You sure ? Looks like W83627HF is handled by the 2nd one, no ?

Re: Sensors (W83627HF) in Tyan S2882

[Fabian Fenaut]

Fabian Fenaut a écrit le 19.04.2004 17:59:
> Jean Delvare a écrit le 19.04.2004 17:18:
> 
>> Nice catching. However the fix is not correct. "W83627HF" is the correct
>> name and "W83682HF" is the typo.
> 
> You sure ? Looks like W83627HF is handled by the 2nd one, no ?

... namely SENSORS_W83627HF

Re: Sensors (W83627HF) in Tyan S2882

[Jean Delvare]

> > Nice catching. However the fix is not correct. "W83627HF" is the
> > correct name and "W83682HF" is the typo.
> 
> You sure ? Looks like W83627HF is handled by the 2nd one, no ?

Sure. Both drivers handle it. The w83267hf driver is prefered if the
chip is found on the ISA bus, however the w83781d is the only one that
can handle the chip if it's on the I2C bus.

For a list of supported chips for each driver, you can take a look at
the comments in the headers of the source files.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Re: Sensors (W83627HF) in Tyan S2882

[Fabian Fenaut]

Jean Delvare wrote:
>>> Nice catching. However the fix is not correct. "W83627HF" is the
>>>  correct name and "W83682HF" is the typo.
>> 
>> You sure ? Looks like W83627HF is handled by the 2nd one, no ?
> 
> Sure. Both drivers handle it. The w83267hf driver is prefered if the
> chip is found on the ISA bus, however the w83781d is the only one 
> that can handle the chip if it's on the I2C bus.
> 
> For a list of supported chips for each driver, you can take a look at
> the comments in the headers of the source files.

Ok, so I suppose this is the appropriate patch :


--- drivers/i2c/chips/Kconfig.orig      2004-04-19 19:05:53.000000000 +0200
+++ drivers/i2c/chips/Kconfig   2004-04-19 19:10:15.000000000 +0200
@@ -163,7 +163,7 @@
         select I2C_SENSOR
         help
           If you say yes here you get support for the Winbond W8378x series
-         of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+         of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
           and the similar Asus AS99127F.

           This driver can also be built as a module.  If so, the module


--
Fabian

Re: Sensors (W83627HF) in Tyan S2882

[Jean Delvare]

> Ok, so I suppose this is the appropriate patch :

Except that it doesn't apply, yes ;)

I suspect that your email client is converting tabs to spaces.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Re: Sensors (W83627HF) in Tyan S2882

[Fabian Fenaut]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

Jean Delvare wrote:
>> Ok, so I suppose this is the appropriate patch :
> 
> Except that it doesn't apply, yes ;)
> 
> I suspect that your email client is converting tabs to spaces.

Sorry, see attachment.

--
Fabian

[-- Attachment #2: patch --]
[-- Type: text/plain, Size: 490 bytes --]

--- drivers/i2c/chips/Kconfig.orig	2004-04-19 19:05:53.000000000 +0200
+++ drivers/i2c/chips/Kconfig	2004-04-19 19:10:15.000000000 +0200
@@ -163,7 +163,7 @@
 	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Winbond W8378x series
-	  of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+	  of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
 	  and the similar Asus AS99127F.
 	  
 	  This driver can also be built as a module.  If so, the module

Re: Sensors (W83627HF) in Tyan S2882

[Jean Delvare]

> > Except that it doesn't apply, yes ;)
> > 
> > I suspect that your email client is converting tabs to spaces.
> 
> Sorry, see attachment.

I forgot to tell you... Patches are prefered in such a form that patch
-p1 from inside the linux directory works. Yours don't. I don't think
Greg will like it. That said, I don't think Greg likes patches as
attachements anyway ;)

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Re: Sensors (W83627HF) in Tyan S2882

[Jan Kasprzak]

Fabian Fenaut wrote:
: Jan Kasprzak a écrit le 19.04.2004 14:01:
: >
: >I have two systems with Tyan S2882 boards (K8S Pro). The sensors chip is
: >Winbond w83627hf according to the mainboard documentation.  The w83627hf 
: >driver can read values from the sensors, but apparently not all values. The
: >board has six fan connectors (two labeled CPU1 fan and CPU2 fan, and four
: >chassis fans). BIOS displays the fan status correctly for all fans, so all
: >fans are connected to the sensors chip. However, there are only three fans
: >listed in /sys/devices/platform/i2c-1/1-0290.
: 
: 
: Probably unrelated to your problem, but isn't there a typo in 
: drivers/i2c/chips/Kconfig ? maybe patch below ?
: 
	Yes, I had CONFIG_SENSORS_W83781D=y. I have recompiled with
CONFIG_SENSORS_W83627HF=y and without CONFIG_SENSORS_W83781D, but the new
kernel still can see only three fans.

-Yenya

-- 
| Jan "Yenya" Kasprzak  <kas at {fi.muni.cz - work | yenya.net - private}> |
| GPG: ID 1024/D3498839      Fingerprint 0D99A7FB206605D7 8B35FCDE05B18A5E |
| http://www.fi.muni.cz/~kas/   Czech Linux Homepage: http://www.linux.cz/ |
 Any compiler or language that likes to hide things like memory allocations
 behind your back just isn't a good choice for a kernel.   --Linus Torvalds

Re: Sensors (W83627HF) in Tyan S2882

[Fabian Fenaut]

Jean Delvare wrote:
>>> Except that it doesn't apply, yes ;)
>>> 
>>> I suspect that your email client is converting tabs to spaces.
>> 
>> Sorry, see attachment.
> 
> 
> I forgot to tell you... Patches are prefered in such a form that
> patch -p1 from inside the linux directory works. Yours don't. I don't
> think Greg will like it. That said, I don't think Greg likes patches
> as attachements anyway ;)


Ok, same player shoot again...


--- linux-2.6.5/drivers/i2c/chips/Kconfig	2004-04-19 21:21:19.000000000 
+0200
+++ edit/drivers/i2c/chips/Kconfig	2004-04-19 21:21:53.000000000 +0200
@@ -163,7 +163,7 @@
  	select I2C_SENSOR
  	help
  	  If you say yes here you get support for the Winbond W8378x series
-	  of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+	  of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
  	  and the similar Asus AS99127F.
  	
  	  This driver can also be built as a module.  If so, the module

Re: Sensors (W83627HF) in Tyan S2882

[Jean Delvare]

> Ok, same player shoot again...

Just perfect :) Thanks.

Greg, please apply. Thanks.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Re: Sensors (W83627HF) in Tyan S2882

[Jean Delvare]

Hi Jan,

> Yes, I had CONFIG_SENSORS_W83781D=y. I have recompiled with
> CONFIG_SENSORS_W83627HF=y and without CONFIG_SENSORS_W83781D, but the
> new kernel still can see only three fans.

I think you need to include the w83627hf driver (for the Winbond
W83627HF chip) and the lm85 driver (for the Analog Devices ADM1027
chip). Don't forget to include the i2c-amd756 and i2c-amd8111 drivers
as well, since the ADM1027 chip has to be connected to either of these
busses.

Hope that helps.

-- 
Jean Delvare
http://www.ensicaen.ismra.fr/~delvare/

Re: Sensors (W83627HF) in Tyan S2882

[Greg KH]

On Mon, Apr 19, 2004 at 09:57:22PM +0200, Fabian Fenaut wrote:
> Jean Delvare wrote:
> >>>Except that it doesn't apply, yes ;)
> >>>
> >>>I suspect that your email client is converting tabs to spaces.
> >>
> >>Sorry, see attachment.
> >
> >
> >I forgot to tell you... Patches are prefered in such a form that
> >patch -p1 from inside the linux directory works. Yours don't. I don't
> >think Greg will like it. That said, I don't think Greg likes patches
> >as attachements anyway ;)
> 
> 
> Ok, same player shoot again...

For some reason this patch doesn't apply at all.  Care to rediff against
the next -mm release and resend it to me?

thanks,

greg k-h

Re: Sensors (W83627HF) in Tyan S2882

[Jean Delvare]

> For some reason this patch doesn't apply at all.  Care to rediff
> against the next -mm release and resend it to me?

Actually the patch wasn't as perfect as I first thought, there were
still indentation issues. I had to rework it a bit so that it would
apply. Here is my modified version.

Thanks.

--- linux-2.6.5/drivers/i2c/chips/Kconfig	2004-04-19 21:21:19.000000000 +0200
+++ edit/drivers/i2c/chips/Kconfig	2004-04-19 21:21:53.000000000 +0200
@@ -163,7 +163,7 @@
 	select I2C_SENSOR
 	help
 	  If you say yes here you get support for the Winbond W8378x series
-	  of sensor chips: the W83781D, W83782D, W83783S and W83682HF,
+	  of sensor chips: the W83781D, W83782D, W83783S and W83627HF,
 	  and the similar Asus AS99127F.
 	  
 	  This driver can also be built as a module.  If so, the module



-- 
Jean Delvare
http://khali.linux-fr.org/

Re: Sensors (W83627HF) in Tyan S2882

[Greg KH]

On Sun, May 02, 2004 at 02:01:58PM +0200, Jean Delvare wrote:
> > For some reason this patch doesn't apply at all.  Care to rediff
> > against the next -mm release and resend it to me?
> 
> Actually the patch wasn't as perfect as I first thought, there were
> still indentation issues. I had to rework it a bit so that it would
> apply. Here is my modified version.

Applied, thanks.

greg k-h