Re: swsusp: fix error handling in "not enough swap space"

[Grzegorz Piotr Jaskiewicz <gj@pointblue.com.pl>]

Pavel Machek wrote:

>>Second one, starting KDE, and when swap usage != 0 (just to be sure 
>>there is no problem with any assumption), gives me loads of error 
>>messages (see attached file).
>>    
>>
>
>Can you try CONFIG_PREEMPT=n?
>	
>
Funny, now it doesn't run BUG(), but, instead I have two way behavior. 
Either he is complaining that bash
will not stop !! or that there is not enough pages free. Both wrong and 
bizzareus. This really needs fixing before 2.6.6 is out (imo).


1:

Apr 25 09:47:58 nalesnik kernel: Stopping tasks: 
========================================================================
Apr 25 09:47:58 nalesnik kernel:  stopping tasks failed (1 tasks remaining)
Apr 25 09:47:58 nalesnik kernel: Suspend failed: Not all processes stopped!
Apr 25 09:47:58 nalesnik kernel: Restarting tasks...<6> Strange, bash 
not stopped


2:

Apr 25 10:53:52 nalesnik kernel: Stopping tasks: 
=======================================================================|
Apr 25 10:53:52 nalesnik kernel: Freeing memory: ..........|
Apr 25 10:53:52 nalesnik kernel: /critical section: counting pages to 
copy..[nosave pfn 0x44d]........................... (pages needed: 
24493+512=25005 free: 4162)
Apr 25 10:53:52 nalesnik kernel: Suspend Machine: Couldn't get enough 
free pages, on 20843 pages short
Apr 25 10:53:52 nalesnik kernel: Suspend Machine: Suspend failed, trying 
to recover...
Apr 25 10:53:52 nalesnik kernel: blk: queue c6d40e00, I/O limit 4095Mb 
(mask 0xffffffff)
Apr 25 10:53:52 nalesnik kernel: Fixing swap signatures... ok
Apr 25 10:53:52 nalesnik kernel: Restarting tasks... done



--
GJ