===== drivers/scsi/sata_sis.c 1.3 vs edited ===== --- 1.3/drivers/scsi/sata_sis.c Thu Apr 22 00:49:04 2004 +++ edited/drivers/scsi/sata_sis.c Sun Apr 25 14:54:20 2004 @@ -34,10 +34,18 @@ #include #define DRV_NAME "sata_sis" -#define DRV_VERSION "0.04" +#define DRV_VERSION "0.10" enum { sis_180 = 0, + SIS_SCR_PCI_BAR = 5, + + /* PCI configuration registers */ + SIS_GENCTL = 0x54, /* IDE General Control register */ + + /* random bits */ + SIS_FLAG_CFGSCR = (1 << 30), + GENCTL_IOMAPPED_SCR = (1 << 26), }; static int sis_init_one (struct pci_dev *pdev, const struct pci_device_id *ent); @@ -99,20 +107,62 @@ MODULE_LICENSE("GPL"); MODULE_DEVICE_TABLE(pci, sis_pci_tbl); +static unsigned int get_scr_cfg_addr(unsigned int port_no, unsigned int sc_reg) +{ + unsigned int addr = 0; + switch (sc_reg) { + case SCR_STATUS: + addr = 0xc0; + break; + case SCR_CONTROL: + addr = 0xc8; + break; + default: + return 0xffffffff; + } + if (port_no) + addr += 0x10; + + return addr; +} + +static u32 sis_scr_cfg_read (struct ata_port *ap, unsigned int sc_reg) +{ + u32 val; + unsigned int cfg_addr = get_scr_cfg_addr(ap->port_no, sc_reg); + if (cfg_addr == 0xffffffff) + return 0xffffffff; + pci_read_config_dword(ap->host_set->pdev, cfg_addr, &val); + return val; +} + +static void sis_scr_cfg_write (struct ata_port *ap, unsigned int sc_reg, u32 val) +{ + unsigned int cfg_addr = get_scr_cfg_addr(ap->port_no, sc_reg); + if (cfg_addr == 0xffffffff) + return; + pci_write_config_dword(ap->host_set->pdev, cfg_addr, val); +} static u32 sis_scr_read (struct ata_port *ap, unsigned int sc_reg) { - if (sc_reg >= 16) + if (sc_reg > SCR_CONTROL) return 0xffffffffU; + if (ap->flags & SIS_FLAG_CFGSCR) + return sis_scr_cfg_read(ap, sc_reg); return inl(ap->ioaddr.scr_addr + (sc_reg * 4)); } static void sis_scr_write (struct ata_port *ap, unsigned int sc_reg, u32 val) { - if (sc_reg >= 16) + if (sc_reg > SCR_CONTROL) return; - outl(val, ap->ioaddr.scr_addr + (sc_reg * 4)); + + if (ap->flags & SIS_FLAG_CFGSCR) + sis_scr_cfg_write(ap, sc_reg, val); + else + outl(val, ap->ioaddr.scr_addr + (sc_reg * 4)); } /* move to PCI layer, integrate w/ MSI stuff */ @@ -131,6 +181,7 @@ { struct ata_probe_ent *probe_ent = NULL; int rc; + u32 genctl; rc = pci_enable_device(pdev); if (rc) @@ -160,6 +211,23 @@ probe_ent->sht = &sis_sht; probe_ent->host_flags = ATA_FLAG_SATA | ATA_FLAG_SATA_RESET | ATA_FLAG_NO_LEGACY; + + /* check and see if the SCRs are in IO space or PCI cfg space */ + pci_read_config_dword(pdev, SIS_GENCTL, &genctl); + if ((genctl & GENCTL_IOMAPPED_SCR) == 0) + probe_ent->host_flags |= SIS_FLAG_CFGSCR; + + /* if hardware thinks SCRs are in IO space, but there are + * no IO resources assigned, change to PCI cfg space. + */ + if ((!(probe_ent->host_flags & SIS_FLAG_CFGSCR)) && + ((pci_resource_start(pdev, SIS_SCR_PCI_BAR) == 0) || + (pci_resource_len(pdev, SIS_SCR_PCI_BAR) < 128))) { + genctl &= ~GENCTL_IOMAPPED_SCR; + pci_write_config_dword(pdev, SIS_GENCTL, genctl); + probe_ent->host_flags |= SIS_FLAG_CFGSCR; + } + probe_ent->pio_mask = 0x03; probe_ent->udma_mask = 0x7f; probe_ent->port_ops = &sis_ops; @@ -169,14 +237,18 @@ probe_ent->port[0].ctl_addr = pci_resource_start(pdev, 1) | ATA_PCI_CTL_OFS; probe_ent->port[0].bmdma_addr = pci_resource_start(pdev, 4); - probe_ent->port[0].scr_addr = pci_resource_start(pdev, 5); + if (!(probe_ent->host_flags & SIS_FLAG_CFGSCR)) + probe_ent->port[0].scr_addr = + pci_resource_start(pdev, SIS_SCR_PCI_BAR); probe_ent->port[1].cmd_addr = pci_resource_start(pdev, 2); ata_std_ports(&probe_ent->port[1]); probe_ent->port[1].ctl_addr = pci_resource_start(pdev, 3) | ATA_PCI_CTL_OFS; probe_ent->port[1].bmdma_addr = pci_resource_start(pdev, 4) + 8; - probe_ent->port[1].scr_addr = pci_resource_start(pdev, 5) + 64; + if (!(probe_ent->host_flags & SIS_FLAG_CFGSCR)) + probe_ent->port[1].scr_addr = + pci_resource_start(pdev, SIS_SCR_PCI_BAR) + 64; probe_ent->n_ports = 2; probe_ent->irq = pdev->irq;