From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-181.mta0.migadu.com (out-181.mta0.migadu.com [91.218.175.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2F473137930 for ; Sat, 6 Jul 2024 15:41:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720280472; cv=none; b=ZzO3q6o4HqYYWe7lSgHieXORYEVdI9bzW6zAsKat6jFFX5jS4OYgfwJAm5qWq1pxoPEIsrizCem04FB/ZUQSahq2kEgsv3fhmrl8CXMXjjcUD4Ja/DppFsVkJ+UOb3UD0QPaiTaJTjHL2yTqWiZUWYCrcy/OPc8NBdRzgq7m0cU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720280472; c=relaxed/simple; bh=M9jRDBpbXwZ4EmwaQHnuGlnqvEpiyG3lM49RlqDVwbU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=PhOJwsvcE4Od2DGNWkd6XcSZoBvdGMWsJ6QSqmUxzceiqQ4EeAdAVo7uKjkCnWY4hAdXdN8I2iol3qJ0Pb/ans55UkXKwKoEUUye1+xu8/MMDxcei56jvpQvRy5zbZ12bfG0enfdGIiADar9Zkm9mz0SWDB0enNQsiHmZzyjscU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=BJ8pW5Cg; arc=none smtp.client-ip=91.218.175.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="BJ8pW5Cg" X-Envelope-To: dan.carpenter@linaro.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1720280466; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=VHyX+ItlOF80ZtMIh6eOxVSUOn43OMD99j3+D49eFXM=; b=BJ8pW5CgQiMSF9nGLg3xKq2Nn38oV8dpQ+4hEKBu8lC+ozyGcn7toD/hvL5perN/YhKSbi i0koOgsQf6LzOsG+xd0U6r/OKJYYatMPoFak7BHcVKr/FZvGu44FBscUah4Sk+89qr5rzP iMqBP8zvY4LLUCbgFtjJrZtx6hvZBs4= X-Envelope-To: brauner@kernel.org X-Envelope-To: ast@kernel.org X-Envelope-To: daniel@iogearbox.net X-Envelope-To: andrii@kernel.org X-Envelope-To: martin.lau@linux.dev X-Envelope-To: eddyz87@gmail.com X-Envelope-To: song@kernel.org X-Envelope-To: john.fastabend@gmail.com X-Envelope-To: kpsingh@kernel.org X-Envelope-To: sdf@fomichev.me X-Envelope-To: haoluo@google.com X-Envelope-To: jolsa@kernel.org X-Envelope-To: bpf@vger.kernel.org X-Envelope-To: linux-kernel@vger.kernel.org X-Envelope-To: kernel-janitors@vger.kernel.org Message-ID: <40958285-12dc-4beb-8085-53f0bb35a989@linux.dev> Date: Sat, 6 Jul 2024 08:40:55 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Subject: Re: [PATCH bpf-next] bpf: remove unnecessary loop in task_file_seq_get_next() To: Dan Carpenter , Christian Brauner Cc: Alexei Starovoitov , Daniel Borkmann , Andrii Nakryiko , Martin KaFai Lau , Eduard Zingerman , Song Liu , John Fastabend , KP Singh , Stanislav Fomichev , Hao Luo , Jiri Olsa , bpf@vger.kernel.org, linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org References: Content-Language: en-GB X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Yonghong Song In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_OUT On 7/4/24 8:19 AM, Dan Carpenter wrote: > After commit 0ede61d8589c ("file: convert to SLAB_TYPESAFE_BY_RCU") this > loop always iterates exactly one time. Delete the for statement and pull > the code in a tab. > > Signed-off-by: Dan Carpenter LGTM. Thanks for the cleanup. Acked-by: Yonghong Song