From: David Vrabel <dvrabel@arcom.com>
To: linux-kernel@vger.kernel.org
Cc: dahinds@users.sourceforge.net
Subject: [PCMCIA] [2.4] TI CardBus PCI interrupt routing fix.
Date: Thu, 13 May 2004 17:06:10 +0100 [thread overview]
Message-ID: <40A39CF2.3060406@arcom.com> (raw)
[-- Attachment #1: Type: text/plain, Size: 511 bytes --]
Hi,
ti_intctl() in drivers/pcmcia/ti113x.h tweaks the MFUNC Routing register
to route interrupts via PCI. Currently it clobbers the top 24 bits of
the register.
Also, certain implementations tie INTA and INTB together and use the
MFUNC1 pin as a GPO thus INTB shouldn't be routed in this case.
Attached patch fixes both these issues.
David Vrabel
--
David Vrabel, Design Engineer
Arcom, Clifton Road Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK Web: http://www.arcom.com/
[-- Attachment #2: ti-cardbus-irq-routing-fix --]
[-- Type: text/plain, Size: 989 bytes --]
Index: linux-2.4.24/drivers/pcmcia/ti113x.h
===================================================================
--- linux-2.4.24.orig/drivers/pcmcia/ti113x.h 2004-05-12 17:52:40.000000000 +0100
+++ linux-2.4.24/drivers/pcmcia/ti113x.h 2004-05-13 16:33:53.000000000 +0100
@@ -176,7 +176,8 @@
* --rmk
*/
if (!socket->cap.irq_mask) {
- u8 irqmux, devctl;
+ uint8_t devctl;
+ uint32_t irqmux;
devctl = config_readb(socket, TI113X_DEVICE_CONTROL);
if ((devctl & TI113X_DCR_IMODE_MASK) != TI12XX_DCR_IMODE_ALL_SERIAL) {
@@ -186,7 +187,8 @@
irqmux = config_readl(socket, TI122X_IRQMUX);
irqmux = (irqmux & ~0x0f) | 0x02; /* route INTA */
- irqmux = (irqmux & ~0xf0) | 0x20; /* route INTB */
+ if (!(config_readl(socket, TI113X_SYSTEM_CONTROL) & TI122X_SCR_INTRTIE))
+ irqmux = (irqmux & ~0xf0) | 0x20; /* route INTB if INTA and INTB aren't tied */
config_writel(socket, TI122X_IRQMUX, irqmux);
config_writeb(socket, TI113X_DEVICE_CONTROL, devctl);
reply other threads:[~2004-05-13 16:06 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40A39CF2.3060406@arcom.com \
--to=dvrabel@arcom.com \
--cc=dahinds@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox