Re: [PATCH] HPET driver

[Jeff Garzik <jgarzik@pobox.com>]

Andrew Morton wrote:
> +static inline u64 readq(void *addr)
> +{
> +	return readl(addr) | (((u64)readl(addr + 4)) << 32);
> +}
> +
> +static inline void writeq(u64 v, void *addr)
> +{
> +	writel(v & 0xffffffff, addr);
> +	writel(v >> 32, addr + 4);
> +}


Seems sane, though I wonder about two things:

* better home is probably asm-generic

* It seems to me that a poorly-written writel() macro might prefer some 
guarantee that it's argument is pre-cast to u32.  I dunno if this is 
just paranoia or not.