From: Manfred Spraul <manfred@colorfullife.com>
To: William Lee Irwin III <wli@holomorphy.com>
Cc: mpm@selenic.com, linux-kernel@vger.kernel.org
Subject: Re: slab redzoning
Date: Sat, 22 May 2004 10:43:47 +0200 [thread overview]
Message-ID: <40AF12C3.80902@colorfullife.com> (raw)
In-Reply-To: <20040522082602.GJ2161@holomorphy.com>
William Lee Irwin III wrote:
>On Sat, May 22, 2004 at 10:02:25AM +0200, Manfred Spraul wrote:
>
>
>>Why this change? I've tested my fls(size-1)==fls(size-1-3*4) approach
>>and it always returned the right result: No redzoning between 8181 and
>>8192 bytes, between 16373 and 16384, etc.
>>
>>
>
>It returns a false positive when size + 3*BYTES_PER_WORD == 2**n, e.g.
>size == 16373. Here, fls(size - 1) == 13, but fls(size - 1 + 12) == 13
>while size - 1 + 12 == 16384, where we'd want the check to fail.
>
No, 16373 must fail: After adding 12 bytes the object size would be
16385, which would mean an order==3 allocation.
And 16372 must succeed: 16384 is still an order==2 allocation.
The idea is that there shouldn't be an allocation order increase due to
redzoning, and afaics that doesn't happen, except between 4082 and 4095
bytes.
--
Manfred
next prev parent reply other threads:[~2004-05-22 8:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-22 3:49 slab redzoning William Lee Irwin III
2004-05-22 8:02 ` Manfred Spraul
2004-05-22 8:26 ` William Lee Irwin III
2004-05-22 8:43 ` Manfred Spraul [this message]
2004-05-22 8:52 ` William Lee Irwin III
2004-05-22 12:22 ` Manfred Spraul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40AF12C3.80902@colorfullife.com \
--to=manfred@colorfullife.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mpm@selenic.com \
--cc=wli@holomorphy.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox