From: Brian King <brking@us.ibm.com>
To: hch@infradead.org
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: 2.6.6-mm5
Date: Sat, 22 May 2004 14:03:48 -0500 [thread overview]
Message-ID: <40AFA414.7080402@us.ibm.com> (raw)
In-Reply-To: <20040522094153.GA3672@infradead.org>
hch@infradead.org wrote:
> On Sat, May 22, 2004 at 02:32:18AM -0700, Andrew Morton wrote:
>
>>>code more readable sometimes) or stick a
>>
>>It uses a *ton* of anonymous unions.
>>
>>
>>>#if (__GNUC__ < 3)
>>># error "This driver requires GCC 3.x"
>>>#endif
>>
>>That breaks allfooconfig.
>
>
> Well, the patch currently in -mm also breaks allmodconfig. Just not on
> your arch or with a recent enough compiler, while with this it'll break
> an all arches unless you have a recent enough compiler. And give the
> driver isn't actually ppc specific that sounds like a really bad tradeoff.
I'll pull out the anonymous unions and submit to linux-scsi.
--
Brian King
eServer Storage I/O
IBM Linux Technology Center
next prev parent reply other threads:[~2004-05-22 19:05 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-22 8:36 2.6.6-mm5 Andrew Morton
2004-05-22 9:09 ` 2.6.6-mm5 Jeff Garzik
2004-05-22 9:22 ` 2.6.6-mm5 hch
2004-05-22 9:26 ` 2.6.6-mm5 Andrew Morton
2004-05-22 11:51 ` 2.6.6-mm5 R. J. Wysocki
2004-05-22 9:26 ` 2.6.6-mm5 hch
2004-05-22 9:32 ` 2.6.6-mm5 Andrew Morton
2004-05-22 9:41 ` 2.6.6-mm5 hch
2004-05-22 19:03 ` Brian King [this message]
2004-05-22 9:38 ` 2.6.6-mm5 hch
2004-05-22 9:44 ` 2.6.6-mm5 Jens Axboe
2004-05-22 9:46 ` 2.6.6-mm5 Felipe Alfaro Solana
2004-05-23 15:51 ` 2.6.6-mm5 James Morris
2004-05-22 11:59 ` 2.6.6-mm5 Matthias Andree
2004-05-22 12:19 ` [patch] 2.6.6-mm5: JFFS2_FS_NAND=y compile error Adrian Bunk
2004-05-23 1:01 ` 2.6.6-mm5 Eric W. Biederman
2004-05-23 1:08 ` 2.6.6-mm5 Andrew Morton
2004-05-23 1:15 ` 2.6.6-mm5 Roland Dreier
2004-05-24 16:17 ` 2.6.6-mm5 Matt Mackall
2004-05-24 17:03 ` 2.6.6-mm5 Eric W. Biederman
2004-05-24 17:43 ` 2.6.6-mm5 Roland Dreier
2004-05-25 7:25 ` 2.6.6-mm5 Eric W. Biederman
2004-05-23 2:45 ` 2.6.6-mm5 Eric W. Biederman
2004-05-24 22:11 ` 2.6.6-mm5 (compile stats) John Cherry
2004-05-25 13:53 ` 2.6.6-mm5 Pavel Machek
2004-05-26 12:41 ` 2.6.6-mm5 Anders Gustafsson
2004-05-26 12:49 ` 2.6.6-mm5 Jens Axboe
2004-05-26 12:59 ` 2.6.6-mm5 Anders Gustafsson
2004-05-26 13:03 ` 2.6.6-mm5 Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2004-05-22 10:27 2.6.6-mm5 Oleg Nesterov
2004-05-22 18:02 2.6.6-mm5 Adam Radford
[not found] <1YAd2-6Th-13@gated-at.bofh.it>
[not found] ` <1YPF4-2hJ-11@gated-at.bofh.it>
[not found] ` <1YPOI-2nq-1@gated-at.bofh.it>
[not found] ` <1YRdQ-3pu-5@gated-at.bofh.it>
2004-05-23 11:39 ` 2.6.6-mm5 Andi Kleen
2004-05-23 21:32 ` 2.6.6-mm5 Eric W. Biederman
2004-05-24 0:02 ` 2.6.6-mm5 Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40AFA414.7080402@us.ibm.com \
--to=brking@us.ibm.com \
--cc=akpm@osdl.org \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox