Re: [RFC PATCH] explicitly mark recursion count

Davide Libenzi
2004-06-02T18:37:57Z

On Wed, 2 Jun 2004, [iso-8859-1] Jörn Engel wrote:

> On Wed, 2 June 2004 07:35:39 -0700, Davide Libenzi wrote:
> >
> > Hmmm, I see more data to maintain to support a method that will never be
> > even close to be perfect.
>
> You get it wrong. This is mainly about Bad Code or Insufficient
> Documentation. In general, I want recursions to be removed, full
> stop. So there is not more data, but less.

You're requesting to add and maintain data to feed a tool that catches
only trivially visible recursion. I don't want to waste mine and your time
explaining why your tool will never work, but if you want an hint, you can
start thinking about all functions that sets/pass callbacks and/or sets
operational functions. I don't know if you noticed that, but Linux is
heavily function-pointer driven. Eg, one function setups a set of function
pointers, and another 317 indirectly calls them. Having such comments, not
only makes the maintainance heavier, but gives the false sense of safeness
that once you drop that data in, you're protected against recursion.

- Davide