From: Jeff Garzik <jgarzik@pobox.com>
To: Brad Campbell <brad@wasp.net.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: libata regression 2.6.6-rc1 -> 2.6.6-rc2 located
Date: Sat, 29 May 2004 12:59:39 -0400 [thread overview]
Message-ID: <40B8C17B.307@pobox.com> (raw)
In-Reply-To: <40B8BF05.9020703@wasp.net.au>
Brad Campbell wrote:
> diff -urN linux-2.6.5-a/drivers/scsi/sata_promise.c
> linux-2.6.5-b/drivers/scsi/sata_promise.c
> --- linux-2.6.5-a/drivers/scsi/sata_promise.c 2004-05-29
> 19:53:40.000000000 +0400
> +++ linux-2.6.5-b/drivers/scsi/sata_promise.c 2004-05-29
> 19:41:47.000000000 +0400
> @@ -1180,14 +1180,14 @@
>
> static void pdc_tf_load_mmio(struct ata_port *ap, struct ata_taskfile *tf)
> {
> - if (tf->protocol != ATA_PROT_DMA)
> + if (tf->protocol == ATA_PROT_PIO)
> ata_tf_load_mmio(ap, tf);
> }
>
>
> static void pdc_exec_command_mmio(struct ata_port *ap, struct
> ata_taskfile *tf)
> {
> - if (tf->protocol != ATA_PROT_DMA)
> + if (tf->protocol == ATA_PROT_PIO)
> ata_exec_command_mmio(ap, tf);
> }
Great work, thanks.
Short term, I'll revert this patch. The change was more of a
"preparation for the future", and not strictly required.
I think I understand why, but I'll need to ponder a bit more on the long
term solution.
Jeff
prev parent reply other threads:[~2004-05-29 16:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-05-29 16:49 libata regression 2.6.6-rc1 -> 2.6.6-rc2 located Brad Campbell
2004-05-29 16:59 ` Jeff Garzik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40B8C17B.307@pobox.com \
--to=jgarzik@pobox.com \
--cc=brad@wasp.net.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox