public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Alan Cox <alan@redhat.com>
Cc: linux-kernel@vger.kernel.org, akpm@osdl.org
Subject: Re: PATCH: First cut at fixing the 3c59x power mismanagment
Date: Sun, 30 May 2004 13:22:31 -0400	[thread overview]
Message-ID: <40BA1857.7020708@pobox.com> (raw)
In-Reply-To: <20040530105305.GA5312@devserv.devel.redhat.com>

Alan Cox wrote:
> In Fedora 2 there have been lots of problem reports with 3c59x mostly 
> apparently linked to power handling errors. In particular tools query the
> MII state of down interfaces.
> 
> The changes here
> 
> -	Power the chip up when doing MII, much as e100 does
> -	Fix a case where the error handling issued commands to the chip
> 	while it was in D3 state
> -	Fixed a case where shutdown handling issued commands to the chip
> 	while it was in D3 state
> 
> I don't have enough suitable hardware to do good coverage testing on these
> changes so test reports would be appreciated.


Initial review of the patch looks good, FWIW.

Thanks for poking at this,

	Jeff



      reply	other threads:[~2004-05-30 17:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-30 10:53 PATCH: First cut at fixing the 3c59x power mismanagment Alan Cox
2004-05-30 17:22 ` Jeff Garzik [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40BA1857.7020708@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=akpm@osdl.org \
    --cc=alan@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox