public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Reiser <reiser@namesys.com>
To: Chris Mason <mason@suse.com>
Cc: Vladimir Saveliev <vs@namesys.com>,
	Reiserfs developers mail-list <Reiserfs-Dev@namesys.com>,
	Andrew Morton <akpm@osdl.org>,
	Alexander Zarochentcev <zam@namesys.com>,
	ReiserFS List <reiserfs-list@namesys.com>,
	LKML <linux-kernel@vger.kernel.org>,
	Jeff Mahoney <jeffm@suse.com>
Subject: I would like to see ReiserFS V3 enter a feature freeze real soon.
Date: Mon, 31 May 2004 09:48:00 -0700	[thread overview]
Message-ID: <40BB61C0.5020902@namesys.com> (raw)
In-Reply-To: <1085751695.22636.3163.camel@watt.suse.com>

While I like and appreciate the data journaling stuff, and I think it 
should go in, real soon now I think we should avoid adding new features 
to V3.  Let the mission critical server folks have a reiserfs version 
that only gets bug fixes added to it, and let V4 be for those who want 
excitement.

Are there any things which Chris and Jeff think should go in besides 
data journaling/ordering and bitmap algorithm changes?

Also, I would like to see some serious benchmarks of the bitmap 
algorithm changes before they go in.  They seem nice in theory, and some 
users liked them for their uses, but that does not make a serious 
scientific study.  Such a study has a high chance of making them even 
better.;-)

zam, I view you as the block allocator maintainer, please review that 
bitmap code from Chris.

Chris and Jeff, can you propose a benchmarking plan for the bitmap code?

Hans


Chris Mason wrote:

>On Fri, 2004-05-28 at 09:27, Vladimir Saveliev wrote:
>
>  
>
>>>The good news is that we tracked this one down recently.  2.6.7-rc1
>>>shouldn't do this anymore.
>>>
>>>      
>>>
>>Just out of curiosity, what was it?
>>    
>>
>
>It was a bug in reiserfs_file_write caused by the data=ordered changes. 
>I was dropping i_sem before changing i_size, and the result was that
>writepage was zeroing out bytes it thought was past the end of the file.
>
>See the recent thread with "1352 NUL bytes at the end of a page?" in the
>subject.  The funny part was that we started getting bug reports for
>this on the suse kernel just a few days before Steven Cole reported it,
>so I was able to overlap some of the bug hunting/testing.
>
>-chris
>
>
>
>
>
>  
>


  parent reply	other threads:[~2004-05-31 16:46 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-28 12:28 filesystem corruption (ReiserFS, 2.6.6): regions replaced by \000 bytes David Madore
2004-05-28 12:46 ` Chris Mason
2004-05-28 13:05   ` Lenar Lõhmus
2004-05-28 16:24   ` Tomas Szepe
2004-05-28 16:29     ` Chris Mason
2004-05-28 16:42       ` Pat
2004-05-28 16:54         ` Chris Mason
2004-05-28 16:45       ` Tomas Szepe
2004-05-28 16:55         ` Chris Mason
2004-05-28 16:58         ` Steven Cole
2004-05-29 11:56     ` Lenar Lõhmus
     [not found]   ` <1085750828.1914.385.camel@tribesman.namesys.com>
     [not found]     ` <1085751695.22636.3163.camel@watt.suse.com>
2004-05-31 16:48       ` Hans Reiser [this message]
2004-06-01 11:37         ` I would like to see ReiserFS V3 enter a feature freeze real soon Chris Mason
2004-06-01 17:02           ` Hans Reiser
2004-06-01 18:53             ` Chris Mason

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40BB61C0.5020902@namesys.com \
    --to=reiser@namesys.com \
    --cc=Reiserfs-Dev@namesys.com \
    --cc=akpm@osdl.org \
    --cc=jeffm@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mason@suse.com \
    --cc=reiserfs-list@namesys.com \
    --cc=vs@namesys.com \
    --cc=zam@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox