public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jeff Garzik <jgarzik@pobox.com>
To: Andrew Zabolotny <zap@homelink.ru>
Cc: Greg KH <greg@kroah.com>, linux-kernel@vger.kernel.org
Subject: Re: two patches - request for comments
Date: Tue, 01 Jun 2004 17:23:11 -0400	[thread overview]
Message-ID: <40BCF3BF.3020202@pobox.com> (raw)
In-Reply-To: <20040529124421.28c776cc.zap@homelink.ru>

Andrew Zabolotny wrote:
> No. class_find_device was written for lcd_find_device() and
> backlight_find_device() (framebuffer devices use them). On the other hand,
> the driver that registers the backlight device doesn't have a pointer to the
> class device (well, the lcd_register_device could return it). Since the
> lcd/backlight names are unique anyway, I don't see any problems with that, and
> moreover, it is *registered* by giving it a name, why it should be
> unregistered in a different way?


Typical Linux usage to an item being registered is

	ptr = alloc_foo()
	register_foo(ptr)
	unregister_foo(ptr)
	free_foo()

It is quite unusual to unregister based on name.  Pointers are far more 
likely to be unique, and the programmer is far less likely to screw up 
the unregister operation.

	Jeff



  reply	other threads:[~2004-06-01 21:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-05-28 21:20 two patches - request for comments Andrew Zabolotny
2004-05-28 21:59 ` Todd Poynor
2004-05-29  8:10   ` Andrew Zabolotny
2004-06-01 20:09     ` Todd Poynor
2004-06-01 21:00       ` Andrew Zabolotny
2004-06-02 17:15         ` Greg KH
2004-06-02 21:25           ` Andrew Zabolotny
2004-06-02 21:32           ` Russell King
2004-06-04 20:43             ` Greg KH
2004-05-28 22:10 ` Greg KH
2004-05-29  8:44   ` Andrew Zabolotny
2004-06-01 21:23     ` Jeff Garzik [this message]
2004-06-01 21:57       ` Andrew Zabolotny
2004-06-02 17:12         ` Greg KH
2004-05-29 13:46 ` Denis Vlasenko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40BCF3BF.3020202@pobox.com \
    --to=jgarzik@pobox.com \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zap@homelink.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox