From: Markus Lidel <Markus.Lidel@shadowconnect.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: Problem with ioremap which returns NULL in 2.6 kernel
Date: Wed, 02 Jun 2004 15:49:13 +0200 [thread overview]
Message-ID: <40BDDAD9.5070809@shadowconnect.com> (raw)
In-Reply-To: <40BDD4C9.5070602@pobox.com>
Hello,
Jeff Garzik wrote:
>>> My preferred approach would be: consider that the hardware does not
>>> need the entire 0x8000000-byte area mapped. Plain and simple.
>>> This is a "don't do that" situation, and that renders the other
>>> questions moot :) You should only be mapping what you need to map.
>> Okay, i'll let try it out with only 64MB.
> Why do you need 64MB, even? :)
I don't know how much space i need :-D But why does the device set the
size to 128MB then?
Also now both controllers where found, but the kernel crashes. It could
be because the driver was never used with 2 controllers, but to be sure
i didn't make something wrong with the ioremap here is my patch.
--- a/drivers/message/i2o/i2o_core.c 2004-05-25 00:51:48.822275000 +0200
+++ b/drivers/message/i2o/i2o_core.c 2004-06-01 22:17:55.562844312 +0200
@@ -3664,6 +3664,8 @@
}
size = dev->resource[i].end-dev->resource[i].start+1;
+ if(size>67108864)
+ size = 67108864;
/* Map the I2O controller */
printk(KERN_INFO "i2o: PCI I2O controller at 0x%08X size=%d\n",
memptr, size);
mem = (unsigned long)ioremap(memptr, size);
Simply set size lower :-) Or have i missed something?
Thanks for you help!
Best regards,
Markus Lidel
------------------------------------------
Markus Lidel (Senior IT Consultant)
Shadow Connect GmbH
Carl-Reisch-Weg 12
D-86381 Krumbach
Germany
Phone: +49 82 82/99 51-0
Fax: +49 82 82/99 51-11
E-Mail: Markus.Lidel@shadowconnect.com
URL: http://www.shadowconnect.com
next prev parent reply other threads:[~2004-06-02 13:43 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-01 12:37 Problem with ioremap which returns NULL in 2.6 kernel Markus Lidel
2004-06-01 14:21 ` Jeff Garzik
2004-06-01 15:21 ` Markus Lidel
2004-06-01 17:08 ` Davide Rossetti
2004-06-02 8:59 ` Markus Lidel
2004-06-01 23:32 ` Jeff Garzik
2004-06-02 8:55 ` Markus Lidel
2004-06-02 13:23 ` Jeff Garzik
2004-06-02 13:49 ` Markus Lidel [this message]
2004-06-02 13:46 ` Jeff Garzik
2004-06-02 14:18 ` Markus Lidel
2004-06-02 14:39 ` Richard B. Johnson
2004-06-02 15:26 ` Markus Lidel
2004-06-02 15:45 ` Richard B. Johnson
2004-06-03 2:41 ` Stuart Young
2004-06-03 2:51 ` Jeff Garzik
2004-06-03 8:38 ` Markus Lidel
2004-06-03 11:42 ` Richard B. Johnson
2004-07-16 11:19 ` Richard B. Johnson
2004-06-02 0:09 ` Zwane Mwaikambo
2004-06-02 12:17 ` Markus Lidel
2004-06-04 20:16 ` Zwane Mwaikambo
2004-07-16 17:29 ` Zwane Mwaikambo
2004-07-16 17:30 ` Jeff Garzik
2004-07-17 0:30 ` Markus Lidel
2004-07-17 0:33 ` Markus Lidel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40BDDAD9.5070809@shadowconnect.com \
--to=markus.lidel@shadowconnect.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox