From: Greg Weeks <greg.weeks@timesys.com>
To: linux-kernel@vger.kernel.org
Cc: benh@kernel.crashing.org
Subject: Re: [PATCH] OProfile driver in 2.6
Date: Wed, 02 Jun 2004 13:51:21 -0400 [thread overview]
Message-ID: <40BE1399.2080908@timesys.com> (raw)
In-Reply-To: <20040602183720.GC385@zaniah>
Philippe Elie wrote:
>On Wed, 02 Jun 2004 at 08:50 +0000, Tom Rini wrote:
>
>
>
>>On Wed, Jun 02, 2004 at 11:19:41AM +0200, Jens Schmalzing wrote:
>>
>>
>>
>>>Hi,
>>>
>>>I noticed that the driver for the OProfile profiling system, which
>>>existed in the linuxppc-2.5-benh tree, is disabled in the mainline,
>>>even though the driver still exists. Is there a reason for this? The
>>>attached patch re-enables the driver.
>>>
>>>
>>Because it has never been picked up, aside from when Ben took it into
>>his tree (assuming this is the patch Anton wrote a while back, and not
>>a re-write Ben did). BTW, this is missing a hunk I think, unless the
>>arch/ppc/kernel/time.c changes have already made it in.
>>
>>
>
>Right there is a missing call to profile_hook(regs); in ppc_do_profile()
>
>
The patch I've been using for ppc oprofile is archived here.
http://www.cs.helsinki.fi/linux/linux-kernel/2003-09/1228.html
I've always wondered why it never got picked up.
Greg Weeks
next prev parent reply other threads:[~2004-06-02 17:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-02 9:19 [PATCH] OProfile driver in 2.6 Jens Schmalzing
2004-06-02 15:50 ` Tom Rini
2004-06-02 18:37 ` Philippe Elie
2004-06-02 17:51 ` Greg Weeks [this message]
2004-06-02 20:12 ` Jens Schmalzing
2004-06-02 17:03 ` Philippe Elie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40BE1399.2080908@timesys.com \
--to=greg.weeks@timesys.com \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox