public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nathan Lynch <nathanl@austin.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: Andrew Morton <akpm@osdl.org>
Subject: [PATCH] use c99 struct initializer in hotcpu_notifier
Date: Wed, 02 Jun 2004 16:12:15 -0500	[thread overview]
Message-ID: <40BE42AF.5050005@austin.ibm.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 301 bytes --]

Hi-

The hotcpu_notifier macro does not properly record the given priority in 
the notifier block.  This causes trouble only for callers which specify 
a non-zero priority, of which there are none (yet).

Patch is against 2.6.7-rc2; please apply.

Signed-off-by: Nathan Lynch <nathanl@austin.ibm.com>

[-- Attachment #2: hotcpu_notifier_c99_initializers.patch --]
[-- Type: text/x-patch, Size: 596 bytes --]

--- linux-2.6.5-7.21/include/linux/cpu.h	2004-05-05 12:40:27.000000000 -0500
+++ linux-2.6.5-7.21.new/include/linux/cpu.h	2004-05-06 17:45:55.000000000 -0500
@@ -60,7 +60,8 @@ extern struct semaphore cpucontrol;
 #define unlock_cpu_hotplug()	up(&cpucontrol)
 #define lock_cpu_hotplug_interruptible() down_interruptible(&cpucontrol)
 #define hotcpu_notifier(fn, pri) {				\
-	static struct notifier_block fn##_nb = { fn, pri };	\
+	static struct notifier_block fn##_nb =			\
+		{ .notifier_call = fn, .priority = pri };	\
 	register_cpu_notifier(&fn##_nb);			\
 }
 int cpu_down(unsigned int cpu);

                 reply	other threads:[~2004-06-02 21:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=40BE42AF.5050005@austin.ibm.com \
    --to=nathanl@austin.ibm.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox