* [PATCH] use c99 struct initializer in hotcpu_notifier
@ 2004-06-02 21:12 Nathan Lynch
0 siblings, 0 replies; only message in thread
From: Nathan Lynch @ 2004-06-02 21:12 UTC (permalink / raw)
To: linux-kernel; +Cc: Andrew Morton
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
Hi-
The hotcpu_notifier macro does not properly record the given priority in
the notifier block. This causes trouble only for callers which specify
a non-zero priority, of which there are none (yet).
Patch is against 2.6.7-rc2; please apply.
Signed-off-by: Nathan Lynch <nathanl@austin.ibm.com>
[-- Attachment #2: hotcpu_notifier_c99_initializers.patch --]
[-- Type: text/x-patch, Size: 596 bytes --]
--- linux-2.6.5-7.21/include/linux/cpu.h 2004-05-05 12:40:27.000000000 -0500
+++ linux-2.6.5-7.21.new/include/linux/cpu.h 2004-05-06 17:45:55.000000000 -0500
@@ -60,7 +60,8 @@ extern struct semaphore cpucontrol;
#define unlock_cpu_hotplug() up(&cpucontrol)
#define lock_cpu_hotplug_interruptible() down_interruptible(&cpucontrol)
#define hotcpu_notifier(fn, pri) { \
- static struct notifier_block fn##_nb = { fn, pri }; \
+ static struct notifier_block fn##_nb = \
+ { .notifier_call = fn, .priority = pri }; \
register_cpu_notifier(&fn##_nb); \
}
int cpu_down(unsigned int cpu);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-06-02 21:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-02 21:12 [PATCH] use c99 struct initializer in hotcpu_notifier Nathan Lynch
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox