From: Hans Reiser <reiser@namesys.com>
To: Chris Mason <mason@suse.com>
Cc: "Jörn Engel" <joern@wohnheim.fh-wedel.de>,
reiserfs-dev@namesys.com, linux-kernel@vger.kernel.org
Subject: Re: [STACK] >3k call path in reiserfs
Date: Wed, 09 Jun 2004 10:06:16 -0700 [thread overview]
Message-ID: <40C74388.20301@namesys.com> (raw)
In-Reply-To: <1086800028.10973.258.camel@watt.suse.com>
Chris Mason wrote:
>On Wed, 2004-06-09 at 08:31, Chris Mason wrote:
>
>
>>On Wed, 2004-06-09 at 08:22, Jörn Engel wrote:
>>
>>
>>>reiserfs has some stack-hungry functions as well. Could you put them
>>>on a diet?
>>>
>>>
>>>
>>Yes, we should be able to fix things by getting rid of some of the
>>inlines in a few spots (some funcs are much too large for inlining).
>>I'll send a patch out this morning.
>>
>>
>
>No such luck, the real offender is having tree balance structs on the
>stack. We need to switch to kmalloc for those, which will be mean some
>extra work to make sure we don't schedule at the wrong time.
>
>In other words, not the trivial patch I was hoping for, but I'm cooking
>one up.
>
>-chris
>
>
>
>
>
>
Can you give me some background on whether this is causing real problems
for real users?
next prev parent reply other threads:[~2004-06-09 17:05 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 12:22 [STACK] >3k call path in reiserfs Jörn Engel
2004-06-09 12:31 ` Chris Mason
2004-06-09 16:53 ` Chris Mason
2004-06-09 17:06 ` Hans Reiser [this message]
2004-06-09 17:15 ` Chris Mason
2004-06-09 18:04 ` Hans Reiser
2004-06-09 18:20 ` Dave Jones
2004-06-09 23:40 ` Hans Reiser
2004-06-10 22:35 ` Jörn Engel
2004-06-11 2:49 ` Hans Reiser
2004-06-11 7:03 ` Arjan van de Ven
2004-06-11 13:46 ` Jörn Engel
2004-06-11 16:32 ` Hans Reiser
2004-06-11 16:50 ` Jörn Engel
2004-06-11 17:08 ` Paul Wagland
2004-06-11 17:46 ` Chris Mason
2004-06-11 18:07 ` Hans Reiser
2004-06-11 14:31 ` Timothy Miller
2004-06-11 14:42 ` Jörn Engel
2004-06-09 17:28 ` Jörn Engel
2004-06-09 18:09 ` Hans Reiser
2004-06-09 18:34 ` Jörn Engel
2004-06-09 23:42 ` Hans Reiser
2004-06-11 13:49 ` Jörn Engel
2004-06-11 16:34 ` Hans Reiser
2004-06-09 18:48 ` Chris Mason
2004-06-09 18:53 ` Jörn Engel
2004-06-09 23:44 ` Hans Reiser
2004-06-10 9:08 ` Vladimir Saveliev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40C74388.20301@namesys.com \
--to=reiser@namesys.com \
--cc=joern@wohnheim.fh-wedel.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
--cc=reiserfs-dev@namesys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox