From: Nigel Cunningham <ncunningham@linuxmail.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: Pavel Machek <pavel@suse.cz>,
mochel@digitalimplant.org, linux-kernel@vger.kernel.org,
akpm@zip.com.au
Subject: Re: Fix memory leak in swsusp
Date: Sat, 12 Jun 2004 13:17:30 +1000 [thread overview]
Message-ID: <40CA75CA.2030209@linuxmail.org> (raw)
In-Reply-To: <20040611110314.GA8592@gondor.apana.org.au>
Hi.
Herbert Xu wrote:
[...]
> + pm_pagedir_nosave =
> + memcpy(m, old_pagedir,
> + PAGE_SIZE << pagedir_order);
[...]
> + pagedir_nosave =
> + memcpy(m, old_pagedir, PAGE_SIZE << pagedir_order);
> }
>
> c = eaten_memory;
We were avoiding the use of memcpy because it messes up the preempt count with 3DNow, and
potentially as other unseen side effects. The preempt could possibly simply be reset at resume time,
but the point remains.
Regards,
Nigel
--
Nigel & Michelle Cunningham
C/- Westminster Presbyterian Church Belconnen
61 Templeton Street, Cook, ACT 2614.
+61 (417) 100 574 (mobile)
next prev parent reply other threads:[~2004-06-12 3:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 13:04 Fix memory leak in swsusp Pavel Machek
2004-06-10 10:50 ` Herbert Xu
2004-06-10 10:56 ` Herbert Xu
2004-06-10 20:08 ` Pavel Machek
2004-06-10 21:24 ` Pavel Machek
2004-06-10 23:37 ` Herbert Xu
2004-06-11 9:48 ` Pavel Machek
2004-06-11 10:16 ` Herbert Xu
2004-06-11 10:23 ` Pavel Machek
2004-06-11 11:03 ` Herbert Xu
2004-06-12 3:17 ` Nigel Cunningham [this message]
2004-06-12 4:00 ` Andrew Morton
2004-06-12 11:10 ` Dave Jones
2004-06-13 15:59 ` Pavel Machek
2004-06-12 22:07 ` Nigel Cunningham
2004-06-12 23:32 ` Jeff Sipek
2004-06-13 15:57 ` Pavel Machek
2004-06-13 8:15 ` Herbert Xu
2004-06-12 6:45 ` Herbert Xu
-- strict thread matches above, loose matches on Subject: below --
2004-06-12 10:45 pavel
2004-06-12 22:09 ` Nigel Cunningham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CA75CA.2030209@linuxmail.org \
--to=ncunningham@linuxmail.org \
--cc=akpm@zip.com.au \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=mochel@digitalimplant.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox