From: Corey Minyard <cminyard@mvista.com>
To: "Robert T. Johnson" <rtjohnso@eecs.berkeley.edu>
Cc: minyard@mvista.com, Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: PATCH: 2.6.7-rc3 drivers/char/ipmi/ipmi_devintf.c: user/kernel pointer typo
Date: Mon, 14 Jun 2004 22:44:35 -0500 [thread overview]
Message-ID: <40CE70A3.7040800@mvista.com> (raw)
In-Reply-To: <1086822299.32056.134.camel@dooby.cs.berkeley.edu>
You are obviously right, and it looks like the fix is in the newest
release candidate. Thanks for finding this.
-Corey
Robert T. Johnson wrote:
>Judging from context, I think there's a misplaced "&" in this code that
>can cause stack overflows and other nasty problems. Perhaps it's left
>over from when msgdata was an array instead of a pointer? Let me know
>if you have any questions or I made a mistake.
>
>Best,
>Rob
>
>
>--- linux-2.6.7-rc3-full/drivers/char/ipmi/ipmi_devintf.c.orig Wed Jun 9 12:08:23 2004
>+++ linux-2.6.7-rc3-full/drivers/char/ipmi/ipmi_devintf.c Wed Jun 9 12:07:09 2004
>@@ -199,7 +199,7 @@ static int handle_send_req(ipmi_user_t
> goto out;
> }
>
>- if (copy_from_user(&msgdata,
>+ if (copy_from_user(msgdata,
> req->msg.data,
> req->msg.data_len))
> {
>
>
>
>
>
prev parent reply other threads:[~2004-06-15 3:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-09 23:04 PATCH: 2.6.7-rc3 drivers/char/ipmi/ipmi_devintf.c: user/kernel pointer typo Robert T. Johnson
2004-06-10 1:39 ` viro
2004-06-15 3:44 ` Corey Minyard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40CE70A3.7040800@mvista.com \
--to=cminyard@mvista.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@mvista.com \
--cc=rtjohnso@eecs.berkeley.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox