From: Paul Fulghum <paulkf@microgate.com>
To: Dan Aloni <da-x@colinux.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] missing NULL check in drivers/char/n_tty.c
Date: Mon, 21 Jun 2004 18:56:30 -0500 [thread overview]
Message-ID: <40D775AE.60806@microgate.com> (raw)
In-Reply-To: <20040621224829.GA26607@callisto.yi.org>
Dan Aloni wrote:
>Apropos cleanups in the tty subsystem, what is the purpose of all
>the *_paranoia_check() calls that almost every driver duplicates for
>itself? Perhaps this can be removed.
>
At some time in the distant past, it must have been a brute force
attempt to debug some *serious* problems. I've never had the
need to enable those checks in the last 6 years.
I agree with your thought, and will be removing them from at
least the synclinkxx drivers. The checks clutter the code
with little gain. And cruft like that keeps propogating to new drivers.
--
Paul Fulghum
paulkf@microgate.com
prev parent reply other threads:[~2004-06-21 23:56 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-21 6:38 [PATCH] missing NULL check in drivers/char/n_tty.c Dan Aloni
2004-06-21 6:58 ` Andrew Morton
2004-06-21 7:36 ` Dan Aloni
2004-06-21 7:39 ` Andrew Morton
2004-06-21 8:24 ` Dan Aloni
2004-06-21 15:06 ` Paul Fulghum
2004-06-21 18:46 ` Andrew Morton
2004-06-21 19:52 ` Paul Fulghum
2004-06-21 22:48 ` Dan Aloni
2004-06-21 23:56 ` Paul Fulghum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D775AE.60806@microgate.com \
--to=paulkf@microgate.com \
--cc=da-x@colinux.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox