* [PATCH][2.6] drivers/media/video/tda9840.c: honour return code of i2c_add_driver()
@ 2004-06-22 15:51 Michael Hunold
0 siblings, 0 replies; only message in thread
From: Michael Hunold @ 2004-06-22 15:51 UTC (permalink / raw)
To: Linus Torvalds
Cc: sensors, Andrew Morton, Linux Kernel Mailing List, a.othieno
Hello Linus,
i2c_add_driver() may actually fail, but my driver returns 0
regardless. Thanks to Arthur Othieno <a.othieno@bluewin.ch> for this
obviously correct patch.
Signed-off-by: Michael Hunold <hunold@linuxtv.org>
Signed-off-by: Arthur Othieno <a.othieno@bluewin.ch>
tda9840.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
--- a/drivers/media/video/tda9840.c 2003-12-18 03:59:06.000000000 +0100
+++ b/drivers/media/video/tda9840.c 2004-06-04 18:15:25.000000000 +0200
@@ -268,13 +268,12 @@ static struct i2c_driver driver = {
.command = tda9840_command,
};
-static int tda9840_init_module(void)
+static int __init tda9840_init_module(void)
{
- i2c_add_driver(&driver);
- return 0;
+ return i2c_add_driver(&driver);
}
-static void tda9840_cleanup_module(void)
+static void __exit tda9840_cleanup_module(void)
{
i2c_del_driver(&driver);
}
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-06-22 15:55 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-06-22 15:51 [PATCH][2.6] drivers/media/video/tda9840.c: honour return code of i2c_add_driver() Michael Hunold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox