From: Jeff Garzik <jgarzik@pobox.com>
To: Andrey Panin <pazke@donpac.ru>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, "Brown, Len" <len.brown@intel.com>
Subject: Re: [PATCH 5/6] 2.6.7-mm1, remove unused ASUS K7V-RM DMI quirk
Date: Wed, 23 Jun 2004 10:53:32 -0400 [thread overview]
Message-ID: <40D9996C.3080904@pobox.com> (raw)
In-Reply-To: <10879946911371@donpac.ru>
Andrey Panin wrote:
> BROKEN_ACPI_Sx flag doesn't seem to be used anywhere in the kernel,
> so ASUS K7V-RM can be removed.
>
> Signed-off-by: Andrey Panin <pazke@donpac.ru>
>
> arch/i386/kernel/dmi_scan.c | 17 -----------------
> 1 files changed, 17 deletions(-)
>
> diff -urpN -X /usr/share/dontdiff linux-2.6.7-mm1.vanilla/arch/i386/kernel/dmi_scan.c linux-2.6.7-mm1/arch/i386/kernel/dmi_scan.c
> --- linux-2.6.7-mm1.vanilla/arch/i386/kernel/dmi_scan.c Sun May 23 22:59:58 2004
> +++ linux-2.6.7-mm1/arch/i386/kernel/dmi_scan.c Sun May 23 23:00:53 2004
> @@ -348,17 +348,6 @@ static __init int swab_apm_power_in_minu
> }
>
> /*
> - * ASUS K7V-RM has broken ACPI table defining sleep modes
> - */
> -
> -static __init int broken_acpi_Sx(struct dmi_blacklist *d)
> -{
> - printk(KERN_WARNING "Detected ASUS mainboard with broken ACPI sleep table\n");
> - dmi_broken |= BROKEN_ACPI_Sx;
> - return 0;
> -}
> -
> -/*
> * Toshiba keyboard likes to repeat keys when they are not repeated.
> */
>
> @@ -712,12 +701,6 @@ static __initdata struct dmi_blacklist d
> { local_apic_kills_bios, "ASUS L3C", {
> MATCH(DMI_BOARD_VENDOR, "ASUSTeK Computer INC."),
> MATCH(DMI_BOARD_NAME, "P4_L3C"),
> - NO_MATCH, NO_MATCH
> - } },
> -
> - { broken_acpi_Sx, "ASUS K7V-RM", { /* Bad ACPI Sx table */
> - MATCH(DMI_BIOS_VERSION,"ASUS K7V-RM ACPI BIOS Revision 1003A"),
> - MATCH(DMI_BOARD_NAME, "<K7V-RM>"),
> NO_MATCH, NO_MATCH
> } },
Maybe CC Len Brown on this, to see if he screams? :)
Jeff
next prev parent reply other threads:[~2004-06-23 14:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-23 12:44 [PATCH 0/6] 2.6.7-mm1, port Acer laptop irq routing workaround to new DMI probing Andrey Panin
2004-06-23 12:44 ` [PATCH 1/6] 2.6.7-mm1, port PnP BIOS driver " Andrey Panin
2004-06-23 12:44 ` [PATCH 2/6] 2.6.7-mm1, port sonypi " Andrey Panin
2004-06-23 12:44 ` [PATCH 3/6] 2.6.7-mm1, port PIIX4 SMBUS " Andrey Panin
2004-06-23 12:44 ` [PATCH 4/6] 2.6.7-mm1, port powernow-k7 " Andrey Panin
2004-06-23 12:44 ` [PATCH 5/6] 2.6.7-mm1, remove unused ASUS K7V-RM DMI quirk Andrey Panin
2004-06-23 12:44 ` [PATCH 6/6] 2.6.7-mm1, port APM BIOS driver to new DMI probing Andrey Panin
2004-06-23 14:53 ` Jeff Garzik [this message]
2004-06-23 16:53 ` [PATCH 5/6] 2.6.7-mm1, remove unused ASUS K7V-RM DMI quirk Len Brown
2004-06-24 19:57 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40D9996C.3080904@pobox.com \
--to=jgarzik@pobox.com \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=pazke@donpac.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox