From: Coywolf Qi Hunt <coywolf@greatcn.org>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [PATCH] share all PFN_*
Date: Wed, 30 Jun 2004 16:22:21 +0800 [thread overview]
Message-ID: <40E2783D.5040108@greatcn.org> (raw)
In-Reply-To: <40E162EF.7010607@greatcn.org>
Coywolf Qi Hunt wrote:
> Hello all,
>
> There's too many macros definitions PFN_UP PFN_DOWN PFN_PHYS PFN_ALIGN
> scattered all over.
> How about a patch move them all into one header file(kernel.h or init.h)
> and share only one copy of them like what min and max. I'd like to
> make it.
>
>
> coywolf
>
This patch splits out asm-generic/page.h and includes it at the bottom
of all arch specific page.h's.
This approach is more easy and *safe* than move the macros into kernel.h
or other, and also prepares for future. By nested into page.h, we can make
sure it's no problem to simply remove those definitions without adding new
include statements.
Here is it. http://greatcn.org/~coywolf/patches/2.6/share-PFN.patch
btw, these are all identical replacements, except on arm26(Matt Heler
told me).
Arm26 implementation has done too much on this point.
On arm26: #define PFN_UP(x) (PAGE_ALIGN(x) >> PAGE_SHIFT)
PAGE_ALIGN is no use here since >> followed
--
Coywolf Qi Hunt
Admin of http://GreatCN.org and http://LoveCN.org
prev parent reply other threads:[~2004-06-30 8:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-29 12:39 How about share all PFN_* ? Coywolf Qi Hunt
2004-06-30 8:22 ` Coywolf Qi Hunt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E2783D.5040108@greatcn.org \
--to=coywolf@greatcn.org \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox