From: Timothy Miller <miller@techsource.com>
To: "Randy.Dunlap" <rddunlap@osdl.org>
Cc: Joshua <jhudson@cyberspace.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] restore floppy boot image
Date: Thu, 01 Jul 2004 10:50:04 -0400 [thread overview]
Message-ID: <40E4249C.5090400@techsource.com> (raw)
In-Reply-To: <20040630145506.46d3af16.rddunlap@osdl.org>
Randy.Dunlap wrote:
> On Wed, 30 Jun 2004 17:52:30 -0400 (EDT) Joshua wrote:
>
> | Thanks for the time in reading the patch.
> |
> | Hmm. pop %ax after the jmp is a clear bug. Must have been a zero
> | on the stack when I tested it. <g>
> |
> | For the clobbering of al just before kernel entry, that is badly arranged
> | code although it doesn't matter (mov $0, %al turns out to be no-op).
>
> No-op should be some form/variant of xchg %ax,%ax
> (not mov to %al -- the latter needs to do something.)
He didn't mean it was a "nop". He meant that the operation had no
effect because moving zero to a register which already contains zero
accomplishes nothing.
next prev parent reply other threads:[~2004-07-01 14:31 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-06-30 18:45 [PATCH] restore floppy boot image Joshua
2004-06-30 18:56 ` Brian Gerst
2004-06-30 20:34 ` Timothy Miller
2004-06-30 21:33 ` Timothy Miller
2004-06-30 21:52 ` Joshua
2004-06-30 21:55 ` Randy.Dunlap
2004-07-01 14:50 ` Timothy Miller [this message]
2004-06-30 23:17 ` Tobias Diedrich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40E4249C.5090400@techsource.com \
--to=miller@techsource.com \
--cc=jhudson@cyberspace.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rddunlap@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox