From: Jeff Garzik <jgarzik@pobox.com>
To: Greg Ingram <ingram@symsys.com>
Cc: linux-kernel@vger.kernel.org, tiwai@suse.de,
Jaroslav Kysela <perex@suse.cz>
Subject: Re: via82xx.c vs. sonypi.c i/o region conflict on vaio
Date: Wed, 14 Jul 2004 15:31:44 -0400 [thread overview]
Message-ID: <40F58A20.1090807@pobox.com> (raw)
In-Reply-To: <Pine.LNX.4.44.0407141230550.25786-100000@maestro.symsys.com>
Greg Ingram wrote:
> I modified the sound driver to grab only 128 ports instead of 256 and the
> driver works fine on this hardware. In 2.6.7, it's line 2049 or so of
> sound/pci/via82xx.c:
>
> old: if ((chip->res_port = request_region(chip->port, 256, card->driver)) == NULL) {
> new: if ((chip->res_port = request_region(chip->port, 256, card->driver)) == NULL) {
I don't see any difference between these two lines.
Regardless, I see two bugs:
1) Hardcoding 256 for resource size. Should be using pci_resource_len()
2) via82xx sound driver should be using pci_request_regions() and
pci_release_regions(), not request_region. Doing this eliminates issue #1.
Jeff
next prev parent reply other threads:[~2004-07-14 19:32 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-14 17:42 via82xx.c vs. sonypi.c i/o region conflict on vaio Greg Ingram
2004-07-14 19:31 ` Jeff Garzik [this message]
2004-07-14 19:53 ` Greg Ingram
2004-07-15 9:58 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40F58A20.1090807@pobox.com \
--to=jgarzik@pobox.com \
--cc=ingram@symsys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@suse.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox