From: Nathan Bryant <nbryant@optonline.net>
To: Pavel Machek <pavel@suse.cz>
Cc: linux-scsi@vger.kernel.org, random1@o-o.yi.org,
Luben Tuikov <luben_tuikov@adaptec.com>,
benh@kernel.crashing.org,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: device_suspend() levels [was Re: [patch] ACPI work on aic7xxx]
Date: Tue, 20 Jul 2004 14:10:10 -0400 [thread overview]
Message-ID: <40FD6002.4070206@optonline.net> (raw)
In-Reply-To: <20040720174611.GI10921@atrey.karlin.mff.cuni.cz>
Pavel Machek wrote:
> Hi!
>
>
>>>Can you kill #if 0 code?
>>
>>Yes. This is a work in progress. Interestingly, the ifdef'd-out code was
>>pasted from mptbase.c in the MPT Fusion driver. If it's broken here,
>>it's probably broken there -- seems the state parameter passed to the
>>pci resume callback is intended to be a PCI D state, not an ACPI S
>>state. Can somebody confirm or deny? The kernel is actually passing
>>state 2 (D2) to the driver when I enter ACPI S3, so presumably the same
>>failure could happen to fusion.
>
>
> I'm no longer sure what should be passed there... We'll probably need
> to turn it into enum... Actually swsusp code in -mm actually passes
> value from enum, and mainline swsusp code passes 0/3.
>
> Pavel
Seems to me, aside from whether it's an enum or not, it should represent
a D-state not an ACPI S-state. Some platforms (Power Mac?) probably
implement PCI power management but not in an ACPI way.
next prev parent reply other threads:[~2004-07-20 18:10 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <40FD38A0.3000603@optonline.net>
[not found] ` <20040720155928.GC10921@atrey.karlin.mff.cuni.cz>
[not found] ` <40FD4CFA.6070603@optonline.net>
2004-07-20 17:46 ` device_suspend() levels [was Re: [patch] ACPI work on aic7xxx] Pavel Machek
2004-07-20 18:10 ` Nathan Bryant [this message]
2004-07-20 18:25 ` Benjamin Herrenschmidt
2004-07-20 18:34 ` Nathan Bryant
2004-07-20 19:10 ` Benjamin Herrenschmidt
2004-07-20 19:23 ` Pavel Machek
[not found] ` <40FD82B1.8030704@optonline.net>
2004-07-20 20:41 ` Benjamin Herrenschmidt
2004-07-20 20:50 ` Nathan Bryant
2004-07-20 21:02 ` Benjamin Herrenschmidt
2004-07-24 15:31 ` Nathan Bryant
2004-07-24 16:00 ` Benjamin Herrenschmidt
2004-07-24 16:45 ` Nathan Bryant
2004-07-24 18:35 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40FD6002.4070206@optonline.net \
--to=nbryant@optonline.net \
--cc=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=luben_tuikov@adaptec.com \
--cc=pavel@suse.cz \
--cc=random1@o-o.yi.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox