From: David Ahern <dsahern@kernel.org>
To: Christoph Hellwig <hch@infradead.org>,
Kunwu Chan <chentao@kylinos.cn>,
Tom Herbert <tom@herbertland.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, jkbs@redhat.com, kunwu.chan@hotmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ipv6: Correct/silence an endian warning in ip6_multipath_l3_keys
Date: Wed, 22 Nov 2023 10:51:24 -0800 [thread overview]
Message-ID: <40a08bfe-6470-4fe0-8540-81db17c2bbc4@kernel.org> (raw)
In-Reply-To: <ZV3EmcsEqfFuvW4P@infradead.org>
On 11/22/23 1:06 AM, Christoph Hellwig wrote:
> On Wed, Nov 22, 2023 at 05:04:49PM +0800, Kunwu Chan wrote:
>> Hi Christoph,
>> Thanks for your reply.
>> I also can't guarantee that it's the right thing to do. Just wanted to
>> dispel this warning. If you have any better way, please let me know.
>
> The most likely reason is that it needs an endianess conversion. I
> don't know the answer either, but actually spending a few minutes
> trying to understand the code should allow you to find it out quickly.
>
> Removing a warning for it's own sake when you don't understand it is
> never a good idea.
>
We should be able to set flow_label to __be32 in flow_dissector_key_tags
(and remove a couple ntohl).
Tom: any reason not to do that?
prev parent reply other threads:[~2023-11-22 18:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-22 7:19 [PATCH v3] ipv6: Correct/silence an endian warning in ip6_multipath_l3_keys Kunwu Chan
2023-11-22 7:23 ` Christoph Hellwig
2023-11-22 9:04 ` Kunwu Chan
2023-11-22 9:06 ` Christoph Hellwig
2023-11-22 18:51 ` David Ahern [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40a08bfe-6470-4fe0-8540-81db17c2bbc4@kernel.org \
--to=dsahern@kernel.org \
--cc=chentao@kylinos.cn \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hch@infradead.org \
--cc=jkbs@redhat.com \
--cc=kuba@kernel.org \
--cc=kunwu.chan@hotmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox