From: Florian Fainelli <f.fainelli@gmail.com>
To: Andrew Lunn <andrew@lunn.ch>, Yajun Deng <yajun.deng@linux.dev>
Cc: hkallweit1@gmail.com, linux@armlinux.org.uk, davem@davemloft.net,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: mdio_bus: change the bus name to mdio
Date: Thu, 19 Dec 2024 08:52:04 -0800 [thread overview]
Message-ID: <40cbb576-edd9-40c1-8f7a-8dd6dfa5d7ed@gmail.com> (raw)
In-Reply-To: <f062d436-5448-418a-9969-f1c368e10f8c@lunn.ch>
On 12/19/24 02:20, Andrew Lunn wrote:
> On Thu, Dec 19, 2024 at 06:04:54PM +0800, Yajun Deng wrote:
>> Since all directories under the /sys/bus are bus, we don't need to add a
>> bus suffix to mdio.
>>
>> This is the only one directory with the bus suffix, sysfs-bus-mdio is
>> now a testing ABI, and didn't have Users in it. This is the time to change
>> it before it's moved to the stable ABI.
>
> So are you saying nobody has udev scripts referencing MDIO devices?
> Nobody has scripts accessing the statistics? You don't expect anything
> in userspace to break because of this change?
>
> I personally think it is too late to change this, something will break
> and somebody will report a regression.
It is too late, merging this patch would be breaking ABI and that is not
acceptable.
--
Florian
next prev parent reply other threads:[~2024-12-19 16:52 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-19 10:04 [PATCH net-next v2] net: mdio_bus: change the bus name to mdio Yajun Deng
2024-12-19 10:20 ` Andrew Lunn
2024-12-19 16:52 ` Florian Fainelli [this message]
2024-12-20 1:34 ` Yajun Deng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=40cbb576-edd9-40c1-8f7a-8dd6dfa5d7ed@gmail.com \
--to=f.fainelli@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=yajun.deng@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox