* [PATCH] s390: Fix prototype for execve
@ 2010-08-24 16:25 Jeff Mahoney
2010-08-24 19:58 ` David Howells
2010-08-25 5:32 ` Heiko Carstens
0 siblings, 2 replies; 3+ messages in thread
From: Jeff Mahoney @ 2010-08-24 16:25 UTC (permalink / raw)
To: Linux Kernel Mailing List
Cc: Martin Schwidefsky, Heiko Carstens, David Howells
Commit d7627467b7a8dd6944885290a03a07ceb28c10eb constified the
arguments to execve but missed the s390 prototype.
This patch fixes it up.
Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: David Howells <dhowells@redhat.com>
Signed-off-by: Jeff Mahoney <jeffm@suse.com>
---
arch/s390/kernel/entry.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/arch/s390/kernel/entry.h
+++ b/arch/s390/kernel/entry.h
@@ -42,8 +42,8 @@ long sys_clone(unsigned long newsp, unsi
int __user *parent_tidptr, int __user *child_tidptr);
long sys_vfork(void);
void execve_tail(void);
-long sys_execve(const char __user *name, char __user * __user *argv,
- char __user * __user *envp);
+long sys_execve(const char __user *name, const char __user *const __user *argv,
+ const char __user *const __user *envp);
long sys_sigsuspend(int history0, int history1, old_sigset_t mask);
long sys_sigaction(int sig, const struct old_sigaction __user *act,
struct old_sigaction __user *oact);
--
Jeff Mahoney
SUSE Labs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: Fix prototype for execve
2010-08-24 16:25 [PATCH] s390: Fix prototype for execve Jeff Mahoney
@ 2010-08-24 19:58 ` David Howells
2010-08-25 5:32 ` Heiko Carstens
1 sibling, 0 replies; 3+ messages in thread
From: David Howells @ 2010-08-24 19:58 UTC (permalink / raw)
To: Jeff Mahoney
Cc: dhowells, Linux Kernel Mailing List, Martin Schwidefsky,
Heiko Carstens
Jeff Mahoney <jeffm@suse.com> wrote:
> Commit d7627467b7a8dd6944885290a03a07ceb28c10eb constified the
> arguments to execve but missed the s390 prototype.
>
> This patch fixes it up.
>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
Acked-by: David Howells <dhowells@redhat.com>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] s390: Fix prototype for execve
2010-08-24 16:25 [PATCH] s390: Fix prototype for execve Jeff Mahoney
2010-08-24 19:58 ` David Howells
@ 2010-08-25 5:32 ` Heiko Carstens
1 sibling, 0 replies; 3+ messages in thread
From: Heiko Carstens @ 2010-08-25 5:32 UTC (permalink / raw)
To: Jeff Mahoney; +Cc: Linux Kernel Mailing List, Martin Schwidefsky, David Howells
On Tue, Aug 24, 2010 at 12:25:01PM -0400, Jeff Mahoney wrote:
> Commit d7627467b7a8dd6944885290a03a07ceb28c10eb constified the
> arguments to execve but missed the s390 prototype.
>
> This patch fixes it up.
>
> Cc: Martin Schwidefsky <schwidefsky@de.ibm.com>
> Cc: Heiko Carstens <heiko.carstens@de.ibm.com>
> Cc: David Howells <dhowells@redhat.com>
> Signed-off-by: Jeff Mahoney <jeffm@suse.com>
> ---
>
> arch/s390/kernel/entry.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- a/arch/s390/kernel/entry.h
> +++ b/arch/s390/kernel/entry.h
> @@ -42,8 +42,8 @@ long sys_clone(unsigned long newsp, unsi
> int __user *parent_tidptr, int __user *child_tidptr);
> long sys_vfork(void);
> void execve_tail(void);
> -long sys_execve(const char __user *name, char __user * __user *argv,
> - char __user * __user *envp);
> +long sys_execve(const char __user *name, const char __user *const __user *argv,
> + const char __user *const __user *envp);
> long sys_sigsuspend(int history0, int history1, old_sigset_t mask);
> long sys_sigaction(int sig, const struct old_sigaction __user *act,
> struct old_sigaction __user *oact);
A similar patch just got merged. Thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-08-25 5:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-08-24 16:25 [PATCH] s390: Fix prototype for execve Jeff Mahoney
2010-08-24 19:58 ` David Howells
2010-08-25 5:32 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox