public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nick Piggin <nickpiggin@yahoo.com.au>
To: Dimitri Sivanich <sivanich@sgi.com>
Cc: "Siddha, Suresh B" <suresh.b.siddha@intel.com>,
	Andrew Morton <akpm@osdl.org>, Anton Blanchard <anton@samba.org>,
	Andi Kleen <ak@suse.de>, Ingo Molnar <mingo@elte.hu>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] consolidate sched domains
Date: Mon, 26 Jul 2004 14:05:56 +1000	[thread overview]
Message-ID: <41048324.8070302@yahoo.com.au> (raw)
In-Reply-To: <20040726022202.GA21602@sgi.com>

Dimitri Sivanich wrote:

>On Fri, Jul 23, 2004 at 02:50:46PM -0700, Siddha, Suresh B wrote:
>
>>On Friday 23 July 2004 08:30, Dimitri Sivanich wrote:
>>
>>>Do other architectures need to define their own cpu_sibling_maps, or am I
>>>missing something that would define that for IA64 and others?
>>>
>>Nick means, all the architectures which use CONFIG_SCHED_SMT needs to define 
>>cpu_sibling_map.
>>
>>Nick, aren't you missing the attached fix in your patch?
>>
>>thanks,
>>suresh
>>
>
>Ok, but cpu_to_phys_group() does a lookup in cpu_sibling map:
>__init static int cpu_to_phys_group(int cpu)
>{
>        return first_cpu(cpu_sibling_map[cpu]);
>}
>
>and is called from outside of a CONFIG_SCHED_SMT ifdef here:
>

Yes of course, thank you.

The fix is for cpu_to_phys_group() to just return cpu when 
!CONFIG_SCHED_SMT.



  reply	other threads:[~2004-07-26  4:06 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-23  3:18 [PATCH] consolidate sched domains Nick Piggin
2004-07-23  5:31 ` Ingo Molnar
2004-07-23 15:30 ` Dimitri Sivanich
2004-07-23 21:50   ` Siddha, Suresh B
2004-07-24  3:09     ` Nick Piggin
2004-07-26  2:22     ` Dimitri Sivanich
2004-07-26  4:05       ` Nick Piggin [this message]
2004-07-26 18:06         ` Jesse Barnes
2004-07-27  3:28           ` Nick Piggin
2004-07-27 16:15             ` Jesse Barnes
2004-07-28  1:08               ` Nick Piggin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=41048324.8070302@yahoo.com.au \
    --to=nickpiggin@yahoo.com.au \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=sivanich@sgi.com \
    --cc=suresh.b.siddha@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox