public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Joel Schopp <jschopp@austin.ibm.com>
To: Paul Mackerras <paulus@samba.org>
Cc: akpm@osdl.org, anton@samba.org,
	linuxppc64-dev@lists.linuxppc.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] cpu hotplug ppc64 bug
Date: Tue, 27 Jul 2004 11:20:48 -0500	[thread overview]
Message-ID: <410680E0.1090802@austin.ibm.com> (raw)
In-Reply-To: <16646.21807.210253.45979@cargo.ozlabs.ibm.com>

I think that function pointers are a good idea too.  But I'm not sure 
why that should hold up this patch.  As it stands now all ppc64 
platforms that do hotplug happen to be pSeries.  I don't know of any 
other ppc64 platforms that are not pSeries who plan on doing this in the 
next few years.  The function is already pSeries specific anyway with 
the rtas_stop_self call.

Meanwhile if we do not put this patch in all Power5 machines will be 
unable to do cpu hotplug with a mainline kernel.



> I wanted to do this a bit differently - I was going to make cpu_die be
> a platform-specific function called via a ppc_md function pointer,
> rather than putting very pseries-specific stuff in smp.c, which is
> used on all platforms.  But having been on vacation and then
> travelling, I haven't got to it yet.
> 
> Paul.
> 

      reply	other threads:[~2004-07-27 16:23 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2004-07-26 23:34 [PATCH] cpu hotplug ppc64 bug Joel Schopp
2004-07-27 13:14 ` Paul Mackerras
2004-07-27 16:20   ` Joel Schopp [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=410680E0.1090802@austin.ibm.com \
    --to=jschopp@austin.ibm.com \
    --cc=akpm@osdl.org \
    --cc=anton@samba.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc64-dev@lists.linuxppc.org \
    --cc=paulus@samba.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox