From: Adam Pennington <adamp@andrew.cmu.edu>
To: linux-kernel@vger.kernel.org
Cc: riel@conectiva.com.br
Subject: OOM may be being too nice to killed processes
Date: Sun, 04 Nov 2001 15:36:00 -0500 [thread overview]
Message-ID: <4107440000.1004906160@eunich> (raw)
I may be misunderstanding this, but looking at this portion of code from
the oom task killer... Isn't it dangerous to give a process PF_MEMALLOC and
then only pass it a SIGTERM? My take is that the high priority bump up
should only happen for the force_sig(SIGKILL,p).
/*
* We give our sacrificial lamb high priority and access to
* all the memory it needs. That way it should be able to
* exit() and clear out its resources quickly...
*/
p->counter = 5 * HZ;
p->flags |= PF_MEMALLOC;
/* This process has hardware access, be more careful. */
if (cap_t(p->cap_effective) & CAP_TO_MASK(CAP_SYS_RAWIO)) {
force_sig(SIGTERM, p);
} else {
force_sig(SIGKILL, p);
}
Adam Pennington
reply other threads:[~2001-11-04 20:36 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4107440000.1004906160@eunich \
--to=adamp@andrew.cmu.edu \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox