From: Ben Greear <greearb@candelatech.com>
To: Andrew Morton <akpm@osdl.org>
Cc: Alan Cox <alan@redhat.com>,
jgarzik@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: PATCH: VLAN support for 3c59x/3c90x
Date: Wed, 28 Jul 2004 14:45:47 -0700 [thread overview]
Message-ID: <41081E8B.7030607@candelatech.com> (raw)
In-Reply-To: <20040728143634.0931ee07.akpm@osdl.org>
Andrew Morton wrote:
> Alan Cox <alan@redhat.com> wrote:
>
>>This adds VLAN support to the 3c59x/90x series hardware.
>
>
> Sigh. This has been floating about for ever. My reluctance stemmed
> from largely-theoretical-sounding objections from Don Becker which I
> didn't fully understand at the time and have now forgotten.
>
> Ben, does the patch look complete/correct to you?
I don't have such hardware, but I don't see any obvious problems
with the patch.
In my opinion Becker's complaints were invalid, or maybe I just
didn't understand what he was trying to say. At any rate, lots of
other NICs have supported larger MTUs and VLANs w/out problem, so
it is unlikely that there is a fundamental flaw in accepting larger
frames.
There are patches for tulip floating around too. I have been running
traffic on these patches for a while with no obvious problems
(on 2.4 kernel, however). Jeff, if you want me to re-send this to you,
please let me know!
Ben
--
Ben Greear <greearb@candelatech.com>
Candela Technologies Inc http://www.candelatech.com
next prev parent reply other threads:[~2004-07-28 21:45 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-07-28 12:42 PATCH: VLAN support for 3c59x/3c90x Alan Cox
2004-07-28 21:33 ` Ben Greear
2004-07-28 22:15 ` Alan Cox
2004-07-28 22:30 ` Ben Greear
2004-07-29 17:19 ` Alan Cox
2004-07-28 21:36 ` Andrew Morton
2004-07-28 21:45 ` Ben Greear [this message]
2004-07-29 4:18 ` Willy Tarreau
2004-07-30 2:20 ` Herbert Xu
2004-07-30 12:10 ` Willy Tarreau
2004-07-31 3:57 ` Herbert Xu
2004-07-31 8:33 ` Willy Tarreau
[not found] ` <200407310846.i6V8k3qq006659@uai.com.br>
2004-07-31 8:57 ` Willy Tarreau
2004-07-31 9:34 ` Jeff Garzik
2004-07-31 10:11 ` Willy Tarreau
2004-07-31 14:12 ` Matti Aarnio
2004-07-31 16:18 ` Jeff Garzik
2004-07-31 17:13 ` Ben Greear
2004-07-31 17:03 ` Ben Greear
2004-07-31 17:05 ` Willy Tarreau
2004-07-31 17:21 ` Ben Greear
2004-07-31 20:16 ` Lee Revell
2004-07-31 20:23 ` Willy Tarreau
2004-07-31 20:25 ` Alan Cox
2004-07-31 20:40 ` Lee Revell
2004-08-06 12:30 ` Willy Tarreau
2004-07-31 16:05 ` Jeff Garzik
2004-07-31 16:12 ` Willy Tarreau
2004-07-31 16:26 ` Jeff Garzik
2004-07-31 21:06 ` PATCH-2.4: MTU fix for tulip driver Willy Tarreau
2004-07-31 9:35 ` PATCH: VLAN support for 3c59x/3c90x Herbert Xu
2004-07-31 10:01 ` Willy Tarreau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=41081E8B.7030607@candelatech.com \
--to=greearb@candelatech.com \
--cc=akpm@osdl.org \
--cc=alan@redhat.com \
--cc=jgarzik@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).