Re: [PATCH][PPC32] Makefile cleanups and gcc-3.4+binutils-2.14 check

Andrew Morton
2004-07-28T21:59:31Z

Tom Rini <trini@kernel.crashing.org> wrote:
>
> The following patch does three things. First, it removes all instances
> of:
> ifeq ($(CONFIG_FOO),y)
> AFLAGS += -Wa,-mfoo
> endif
>
> and makes us set them once in arch/ppc/Makefile, via
> aflags-$(CONFIG_FOO), just like we do for CFLAGS. Next it adds a test
> for gcc-3.4 and binutils-2.14. The problem with this combination is
> that the -many flag is broken in binutils-2.14 and gcc-3.4 will pass it
> down, causing other flags to be overridden and the compile to fail.
> Changing gcc or binutils versions fixes this. Finally, it changes
> places in the Makefiles where we did:
> ifeq ($(CONFIG_FOO),y)
> obj-$(CONFIG_BAR) += foo_bar.o
> endif
> into
> obj-$(CONFIG_FOO) += $(bar-y)
> bar-$(CONFIG_BAR) += foo_bar.o

Unfortunately this has significant clashes with the mpc52xx bk tree
which I'm carrying.

That patch has been sitting around for several weeks now - can we get it
merged up first?